Repository navigation
Conversation
flutter-dashboard
Bot
added
the
tool
87f01c2 to
ad0b792
Compare
Co-authored-by: Shi-Hao Hong <[email protected]>
Co-authored-by: Shi-Hao Hong <[email protected]>
|
@HansMuller @jonahwilliams who should review this? |
|
Please note this is now part of a bigger PR #86167. I am leaving the team to decide, whichever lands first. If the big one is ok, this should be closed without review, if we want to take it into steps, then this goes first. |
|
I have no context for the l10n work. I can check over the code but its up to @HansMuller for a final say |
| ..childFile('app_es.arb').writeAsStringSync(selectMessageEsArb); | ||
|
|
||
| try { | ||
| LocalizationsGenerator( |
There was a problem hiding this comment.
You don't need to explicitly fail here, throwing an unhandled exception will already fail the test
There was a problem hiding this comment.
Thanks for your feedback, resolved in the other PR.
|
|
||
| final List<String> cases = <String>[]; | ||
|
|
||
| final RegExp selectRE = RegExp(r'\{([\w\s,]*),\s*select\s*,\s*([\w\d]+\s*\{.*\})+\s*\}'); |
There was a problem hiding this comment.
I would hoist this regex into a static so that it is only compiled once, and additional document a bit what it is intended to match to help future contributors.
|
@jonahwilliams - this project has moved to #86167. I put a link to your comments there. @asashour - It would be best to close this PR in favor of #86167 |
|
Closed as part of #86167 |
5 participants
Fixes #81981
Pre-launch Checklist
///).