Skip to content

Docs improvements for minLines/maxLines - #85138

Merged
justinmc merged 3 commits into
flutter:masterfrom
justinmc:min-max-lines-docs
Jun 24, 2021
Merged

Docs improvements for minLines/maxLines#85138
justinmc merged 3 commits into
flutter:masterfrom
justinmc:min-max-lines-docs

Conversation

@justinmc

@justinmc justinmc commented Jun 23, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

There was confusion over whether minLines and maxLines affect the number of lines of text that can be entered vs. the number of lines visible. This updates the docs to clarify this.

Docs change only, no tests.

Potential fix for #80133

@justinmc
justinmc requested a review from LongCatIsLooong June 23, 2021 16:33
@justinmc justinmc self-assigned this Jun 23, 2021
@flutter-dashboard flutter-dashboard Bot added the framework flutter/packages/flutter repository. See also f: labels. label Jun 23, 2021
@flutter-dashboard

flutter-dashboard Bot commented Jun 23, 2021

Copy link
Copy Markdown

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@google-cla google-cla Bot added the cla: yes label Jun 23, 2021
@justinmc
justinmc force-pushed the min-max-lines-docs branch from 18a4b06 to 96fcbf3 Compare June 23, 2021 17:11
@Piinks Piinks added d: api docs Issues with https://api.flutter.dev/ documentation a: text input Entering text in a text field or keyboard related problems labels Jun 23, 2021
Piinks
Piinks approved these changes Jun 23, 2021
View reviewed changes

@Piinks Piinks left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flutter_LGTM
Pinging @Hixie for test exemption. :)

@Hixie

Hixie commented Jun 23, 2021

Copy link
Copy Markdown
Contributor

test-exempt: only affects comments

btw you typically need a newline before a bullet in our markdown variant, so after landing this please check the output and see if it's what you expect

@justinmc

justinmc commented Jun 23, 2021

Copy link
Copy Markdown
Contributor Author

Thanks all!

I'll write myself a note to check the output. Hopefully it's ok in the way that it combines with the macro...

@justinmc
justinmc merged commit 61e6a72 into flutter:master Jun 24, 2021
@justinmc
justinmc deleted the min-max-lines-docs branch June 24, 2021 16:29
@justinmc justinmc mentioned this pull request Jun 24, 2021
Closed
@justinmc

justinmc commented Aug 23, 2021

Copy link
Copy Markdown
Contributor Author

✅ All docs output looks correct (e.g. https://master-api.flutter.dev/flutter/material/TextField/minLines.html).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Piinks Piinks Piinks approved these changes
@LongCatIsLooong LongCatIsLooong Awaiting requested review from LongCatIsLooong

Assignees

@justinmc justinmc

Labels

a: text input Entering text in a text field or keyboard related problems d: api docs Issues with https://api.flutter.dev/ framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@justinmc @Hixie @Piinks