Repository navigation
[flutter] tab navigation does not notify the focus scope node - #86141
Merged
fluttergithubbot merged 1 commit intoJul 9, 2021
Merged
Conversation
flutter-dashboard
Bot
added
p: material_ui
Contributor
Author
|
this is not a bug, but a side effect of removing focus during clicks. I can fix that separately by doing the removal elsewhere. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discovered while working on #86041, it seems like tab navigation does not cause a notifaction on the focus scope node, which means that the cached focus node is out of date.
I'm not sure if this is intentional or not, but since we don't actually need the listener I can work around it here. Attached test case fails without this change.