Skip to content

Add fixes for AppBar deprecations - #86382

Closed
Piinks wants to merge 12 commits into
flutter:masterfrom
Piinks:fixAppBar
Closed

Add fixes for AppBar deprecations#86382
Piinks wants to merge 12 commits into
flutter:masterfrom
Piinks:fixAppBar

Conversation

@Piinks

@Piinks Piinks commented Jul 13, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

This adds fixes for the deprecations added in #86198

Fixes #74908

It also adds a few missing deprecation notices to the affected api.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard

flutter-dashboard Bot commented Jul 13, 2021

Copy link
Copy Markdown

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@flutter-dashboard flutter-dashboard Bot added p: material_ui material_ui package in flutter/packages framework flutter/packages/flutter repository. See also f: labels. labels Jul 13, 2021
@Piinks Piinks added c: contributor-productivity Team-specific productivity, code health, technical debt. c: tech-debt Technical debt, code quality, testing, etc. labels Jul 13, 2021
@google-cla google-cla Bot added the cla: yes label Jul 13, 2021
@Piinks
Piinks requested a review from goderbauer July 13, 2021 20:58
HansMuller
HansMuller approved these changes Jul 13, 2021
View reviewed changes

@HansMuller HansMuller left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

SystemUiOverlayStyle requires import 'package:flutter/services.dart'; see https://github.com/flutter/gallery/pull/531 which applied the gallery changes.

darrenaustin
darrenaustin approved these changes Jul 13, 2021
View reviewed changes

@darrenaustin darrenaustin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Looks like there are some test failures that Hans had some insight into.

@Piinks

Piinks commented Jul 13, 2021

Copy link
Copy Markdown
Contributor Author

Thanks! Yeah, I can add the import with the fix! :)

@Piinks

Piinks commented Jul 13, 2021

Copy link
Copy Markdown
Contributor Author

So, I added the import, just like we have in another fix, but it is for some reason resulting in ~1000 import statements after running the fix. 🙃

@bwilkerson is there something wrong here?

Output:
output.txt

@flutter-dashboard

flutter-dashboard Bot commented Aug 2, 2021

Copy link
Copy Markdown

This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@Piinks Piinks mentioned this pull request Aug 2, 2021
Closed
@fluttergithubbot

fluttergithubbot commented Aug 16, 2021

Copy link
Copy Markdown
Contributor

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite customer_testing-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.

@Piinks

Piinks commented Aug 16, 2021

Copy link
Copy Markdown
Contributor Author

Not sure why flutter_svg would be broken by this. Checked it out locally with/without this change and the test failure persists, cc @dnfield

@dnfield

dnfield commented Aug 16, 2021

Copy link
Copy Markdown
Contributor

Looks like it may be related to an engine change - does it help if you merge up to head?

@Piinks

Piinks commented Aug 16, 2021

Copy link
Copy Markdown
Contributor Author

This is up to date as of 30 minutes ago, the failure has persisted for a few days now of merging master a couple of times.

@Piinks

Piinks commented Aug 16, 2021

Copy link
Copy Markdown
Contributor Author

Synced again..

@Piinks

Piinks commented Aug 17, 2021

Copy link
Copy Markdown
Contributor Author

Caught up with @dnfield offline, this failure does not appear to make sense with this change, I am going to open a fresh PR to see if it resolves itself.

@Piinks Piinks closed this Aug 17, 2021
@Piinks Piinks mentioned this pull request Aug 17, 2021
Merged
8 tasks done
@Piinks

Piinks commented Aug 17, 2021

Copy link
Copy Markdown
Contributor Author

New PR is #88365

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer Awaiting requested review from goderbauer
2 more reviewers
@darrenaustin darrenaustin darrenaustin approved these changes
@HansMuller HansMuller HansMuller approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. c: tech-debt Technical debt, code quality, testing, etc. framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Write dart fixes for old deprecations/breaking changes

5 participants

@Piinks @fluttergithubbot @dnfield @darrenaustin @HansMuller