Repository navigation
text selection for the web - #86664
Closed
jonahwilliams wants to merge 2 commits into
Closed
jonahwilliams wants to merge 2 commits into
jonahwilliams wants to merge 2 commits into
Conversation
flutter-dashboard
Bot
added
the
framework
jonahwilliams
commented
Jul 19, 2021
| ignoring: ignoreEvents, | ||
| child: child, | ||
| child: SelectionArea( | ||
| enabled: true, // Text selection is only enabled by default for the web. |
Contributor
Author
There was a problem hiding this comment.
Will set to kIsWeb, leaving it this way for testing
jonahwilliams
commented
Jul 19, 2021
| } | ||
|
|
||
| @override | ||
| Widget build(BuildContext context) { |
Contributor
Author
There was a problem hiding this comment.
@gspencergoog I feel like we talked about this before, but I'm unsure why I can't get these shortcuts to fire. i suppose I need the change that allows shortcut keys to fallback to parent shortcuts?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP due to testing / shortcuts questions.
Continuation of #81849
Work towards #81839