Repository navigation
Make hot mode a little less aggressive about catching errors. - #8743
Merged
Merged
Conversation
Contributor
Author
|
This is a minor step towards fixing #8742. |
Contributor
|
LGTM |
Hixie
force-pushed
the
tool_crash
branch
6 times, most recently
from
March 13, 2017 21:10
3d76a23 to
6cfb100
Compare
Contributor
Author
|
Fixed the TODO that I'd left, and caught some other errors that the dependency checker might run into. |
Contributor
|
@Hixie Can we add tests? |
Contributor
Author
|
Yup, I was already on it. :-) |
Hixie
force-pushed
the
tool_crash
branch
2 times, most recently
from
March 13, 2017 21:34
95d931a to
36b5557
Compare
Contributor
Author
|
ok PTAL. Now with some testing and more user-friendly behaviour. |
Contributor
|
LGTM |
It was resulting in weird situations where the tool would dump an error message and stack but not quit, or would fail hard but then just hang. Instead, specifically catch errors you expect. As an example of this, there's one error we expect from the DartDependencySetBuilder, so we catch that one, turn it into a dedicated exception class, then in the caller catch that specific exception.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was resulting in weird situations where the tool would dump an
error message and stack but not quit, or would fail hard but then just
hang.
Instead, specifically catch errors you expect. As an example of this,
there's one error we expect from the DartDependencySetBuilder, so we
catch that one, turn it into a dedicated exception class, then in the
caller catch that specific exception.