Repository navigation
Updated skipped tests for services directory. - #87874
Merged
Merged
Conversation
darrenaustin
added
c: contributor-productivity
flutter-dashboard
Bot
added
the
framework
17 tasks done
darrenaustin
requested review from
Piinks,
ferhatb and
jonahwilliams
and removed request for
ferhatb
August 9, 2021 06:45
| expect(data.physicalKey, equals(PhysicalKeyboardKey.escape)); | ||
| expect(data.logicalKey, equals(LogicalKeyboardKey.escape)); | ||
| expect(data.keyLabel, isEmpty); | ||
| }, skip: isBrowser); // https://github.com/flutter/flutter/issues/35347 |
Contributor
There was a problem hiding this comment.
aren't these Fuchsia specific too? Are they passing because they are working correctly or just passing by mistake?
Contributor
Author
There was a problem hiding this comment.
No, they aren't being run, as they are part of the 'RawKeyEventDataFuchsia' group which has a skip on the entire group below on line 1255. We don't need individual tests in the group skipped for this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #86396.
Updated the skip tests in the 'services' directory. Turned some tests back on, marked some as intentional in a comment or added issues where missing.