Skip to content

Update flutter create templates for Xcode 13 - #88074

Merged
fluttergithubbot merged 1 commit into
flutter:masterfrom
jmagman:migrate-Xcode-check
Aug 12, 2021
Merged

fluttergithubbot merged 1 commit into
flutter:masterfrom
jmagman:migrate-Xcode-check

Conversation

@jmagman

@jmagman jmagman commented Aug 12, 2021 •

Copy link
Copy Markdown
Member

Get rid of the "Update to recommended settings" warning on new iOS and macOS Flutter projects (shows up on all supported versions of Xcode) by marking LastUpgradeCheck and objectVersion as already resolved by Xcode 13.

Screen Shot 2021-08-11 at 4 18 11 PM

  • Let Xcode change whitespace, split out SWIFT_COMPILATION_MODE from SWIFT_OPTIMIZATION_LEVEL, and rearrange the scheme metadata.
  • Add missing Flutter.xcconfig file to the host module template (it was already referenced, but not in all the necessary places)

Unfortunately the "Update to recommended settings" warning is only visible in the Xcode GUI, not from the command line output, so I don't see an easy way to test if it's missing.

Update unit tests, add macOS create test.

@jmagman jmagman added platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. platform-macos Building on or for macOS specifically t: xcode "xcodebuild" on iOS and general Xcode project management labels Aug 12, 2021
@jmagman jmagman self-assigned this Aug 12, 2021
@google-cla google-cla Bot added the cla: yes label Aug 12, 2021
<?xml version="1.0" encoding="UTF-8"?>
<Scheme
LastUpgradeVersion = "1020"
LastUpgradeVersion = "1300"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

out of curiosity, what is 1020 and 1300 mean? are these constant codes?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the version of Xcode that last checked if anything needed to be updated. The last time we updated this was Xcode 10.2. This change updates to Xcode 13.0.

@christopherfujino christopherfujino left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot
fluttergithubbot merged commit 9b1ed46 into flutter:master Aug 12, 2021
@jmagman
jmagman deleted the migrate-Xcode-check branch August 12, 2021 18:39

@cbracken cbracken left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woohoo! (Post-submit) lgtm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

platform-ios iOS applications specifically platform-macos Building on or for macOS specifically t: xcode "xcodebuild" on iOS and general Xcode project management tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants