Skip to content

Fixed leak and removed no-shuffle tag in long_press_test.dart - #88373

Merged
gspencergoog merged 1 commit into
flutter:masterfrom
Swiftaxe:85160_long_press_test
Aug 23, 2021
Merged

gspencergoog merged 1 commit into
flutter:masterfrom
Swiftaxe:85160_long_press_test

Conversation

@Swiftaxe

Copy link
Copy Markdown
Contributor

Fixes test/gestures/long_press_test.dart of #85160

The LongPressGestureRecognizer in test 'non-allowed pointer does not inadvertently reset the recognizer' was not disposed breaking a lot of other tests.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard Bot added the framework flutter/packages/flutter repository. See also f: labels. label Aug 17, 2021
@google-cla google-cla Bot added the cla: yes label Aug 17, 2021
@gspencergoog
gspencergoog self-requested a review August 23, 2021 16:55

@gspencergoog gspencergoog left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@gspencergoog
gspencergoog merged commit 60ed5cc into flutter:master Aug 23, 2021
@Swiftaxe
Swiftaxe deleted the 85160_long_press_test branch September 11, 2021 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants