Repository navigation
Conversation
flutter-dashboard
Bot
added
p: material_ui
|
Gold has detected about 10 new digest(s) on patchset 3. |
|
Gold has detected about 7 new digest(s) on patchset 4. |
|
Gold has detected about 10 new digest(s) on patchset 6. |
|
Gold has detected about 1 new digest(s) on patchset 7. |
3a70ed9 to
b0d5f21
Compare
|
Gold has detected about 4 new digest(s) on patchset 7. |
|
Closing this until I have time to return to it. |
|
@justinmc do you remember if this was looking promising or if it ran into some problems? FWIW, I would definitely support efforts to remove FocusTrap entirely. |
|
I'm going to update this PR and see if tests pass, etc. I remember really doubting myself that I could make this work with such a simple change, but I can't remember if I specifically ran into any major blockers. |
|
@Hixie Here's the major blocker: the tests don't pass on web because the onTapDown is swallowing gestures. For example, for iOS's swipe back gesture, the onHorizontalDragUpdate is never called when the onTapDown is in the tree above it. I imagine this can be solved with a custom tap gesture detector or something like that? If I get more time maybe I can figure out something that works. |
3 participants
This is a proposal to replace FocusTrap with a root Focus instead, in order to:
TODO
Related issues
Fixes #86972
Unblocks #76072
Original FocusTrap PR: #82575
Follow up that fixed clicks on prefix/suffix: #86041