Skip to content

Fixed toggleableActiveColor - #90317

Closed
sm2017 wants to merge 1 commit into
flutter:masterfrom
sm2017:patch-2
Closed

sm2017 wants to merge 1 commit into
flutter:masterfrom
sm2017:patch-2

Conversation

@sm2017

@sm2017 sm2017 commented Sep 18, 2021

Copy link
Copy Markdown

I upgraded my flutter from 2.3 to 2.5 and fixes all deprecation including

info: 'accentColor' is deprecated and shouldn't be used. Use colorScheme.secondary instead. For more information, consult the migration guide at https://flutter.dev/docs/release/breaking-changes/theme-data-accent-properties#migration-guide. This feature was deprecated after v2.3.0-0.1.pre..

I just figured out that the color of checkbox is not true

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@google-cla google-cla Bot added the cla: yes label Sep 18, 2021
@goderbauer goderbauer added p: material_ui material_ui package in flutter/packages framework flutter/packages/flutter repository. See also f: labels. labels Sep 27, 2021
@Hixie
Hixie requested a review from goderbauer December 8, 2021 00:14
@goderbauer

Copy link
Copy Markdown
Member

@sm2017 Looks like this PR is failing checks. Can you please take a look at those? And while you're at it, resolve the merge conflict? Thanks!

@sm2017

sm2017 commented Dec 8, 2021

Copy link
Copy Markdown
Author

Sorry I'm too busy

@goderbauer

Copy link
Copy Markdown
Member

Ok. I am going to close this for now. Please feel free to re-open if you find the time to finish this PR. Thanks!

@goderbauer goderbauer closed this Dec 14, 2021
@TahaTesser TahaTesser mentioned this pull request Apr 22, 2022
8 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants