Repository navigation
Conversation
There was a problem hiding this comment.
Can we tag this cipd ref as version:96 to make it easier to audit?
There was a problem hiding this comment.
Do you have the command line to do this?
There was a problem hiding this comment.
cipd set-tag flutter_internal/browsers/chrome/linux-amd64 -tag version:96 -version kkOzlCHhXTi3TpU7miUzqSOCVa_2RJVb09kfze0a6z0C
There was a problem hiding this comment.
In this case, what does latest indicate? Are there multiple releases of 96?
There was a problem hiding this comment.
I'm not sure. I'm reusing the one we already have: https://chrome-infra-packages.appspot.com/p/flutter_internal/browsers/chrome/linux-amd64/+/
There was a problem hiding this comment.
I'm finding out from @hterkelsen if I should maybe use 927388 instead.
There was a problem hiding this comment.
There was a problem hiding this comment.
I think verson: 96 is the way to go. We have been making other cipd packages following this consistent format, like android version: https://chrome-infra-packages.appspot.com/p/flutter_internal/android/sdk/linux-amd64/+/56xIdLBDFMMlbbbtLk_9czg8NB-4GjFIbxf5h3-BixQC
/cc @godofredoc
There was a problem hiding this comment.
That's correct, we are moving towards pinning explicit versions in the ci.yaml file.
|
Gold has detected about 10 new digest(s) on patchset 2. |
|
Gold has detected about 7 new digest(s) on patchset 3. |
goderbauer
added
c: contributor-productivity
|
This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
This is a change that will enable some progress on this issue: flutter/packages#518 |
6 participants
Update test Chromium version to the CIPD package corresponding to Chromium 96. Add Chromium versions in some dependencies that didn't specify it.