Repository navigation
Add Pods cache dir to ios/.gitignore - #9464
Merged
Merged
Conversation
cbracken
approved these changes
Apr 19, 2017
cbracken
left a comment
cbracken
left a comment
Member
There was a problem hiding this comment.
LGTM. Thanks.
On my phone so wasn't able to expand the diff and see if we're using blank lines as section dividers.
| /Flutter/Generated.xcconfig | ||
| /ServiceDefinitions.json | ||
|
|
||
| Pods/ No newline at end of file |
Member
There was a problem hiding this comment.
nit: blank line, missing newline at end
Member
Author
There was a problem hiding this comment.
Added the missing newline.
The blank line was intentional; the file is already formatted into logical groupings, and I wanted to stay consistent with that.
Member
There was a problem hiding this comment.
Thanks! Wondered if that might be the case -- github doesn't allow expanding collapsed regions on phones :(
(and thanks for making this change!)
Member
Author
|
Merging. The broken flutter-build appears to be a flake as it passed in a re-run. |
8 of 9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9085