Repository navigation
CocoaPods flow step 1 - #9687
Merged
Merged
Conversation
xster
requested review from
cbracken,
collinjackson,
jakobr-google and
sethladd
April 29, 2017 02:01
collinjackson
approved these changes
Apr 29, 2017
collinjackson
left a comment
collinjackson
left a comment
Contributor
There was a problem hiding this comment.
looks good, thanks
A few minor wording suggestions that you can take or leave as you like
| } | ||
|
|
||
| final String noCocoaPodsConsequence = ''' | ||
| CocoaPods is used to retrieve the native platform side's plugin code that responds to your |
Contributor
There was a problem hiding this comment.
Maybe instead of native platform you could say iOS
| final String noCocoaPodsConsequence = ''' | ||
| CocoaPods is used to retrieve the native platform side's plugin code that responds to your | ||
| plugin usage on the Dart side. | ||
| Without resolving native dependencies with CocoaPods, plugins usage will not work on iOS. |
Contributor
There was a problem hiding this comment.
I would remove the word "usage" here
Contributor
There was a problem hiding this comment.
I'm not sure the word native is necessary here and that words is a bit overloaded.
jakobr-google
approved these changes
Apr 29, 2017
jakobr-google
left a comment
jakobr-google
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks!
I agree with Collin - 'native' is a bit overloaded, and this is only for iOS, so we can be specific.
collinjackson
approved these changes
May 1, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #9580 and #9035
Just add some explanations for why cocoapods is there. Will reduce the scope of users it's shown to in #9686.