Skip to content

[WIP] Removed deprecated property disabledThumbGapWidth - #98568

Closed
amanv8060 wants to merge 2 commits into
flutter:masterfrom
amanv8060:RectangularSliderTrackShape.disabledThumbGapWidth
Closed

[WIP] Removed deprecated property disabledThumbGapWidth#98568
amanv8060 wants to merge 2 commits into
flutter:masterfrom
amanv8060:RectangularSliderTrackShape.disabledThumbGapWidth

Conversation

@amanv8060

@amanv8060 amanv8060 commented Feb 16, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Remove disabledThumbGapWidth property deprecated in #65246

dart fix support already there : link to relevant fix

Part of issue: #98537

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard Bot added p: material_ui material_ui package in flutter/packages framework flutter/packages/flutter repository. See also f: labels. labels Feb 16, 2022
@amanv8060 amanv8060 mentioned this pull request Feb 16, 2022
Closed
@amanv8060 amanv8060 changed the title [WIP] Removed deprecated property [WIP] Removed deprecated property disabledThumbGapWidth Feb 16, 2022
@amanv8060
amanv8060 marked this pull request as ready for review February 16, 2022 14:44
@flutter-dashboard

flutter-dashboard Bot commented Feb 16, 2022

Copy link
Copy Markdown

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@Piinks

Piinks commented Feb 16, 2022

Copy link
Copy Markdown
Contributor

Hey @amanv8060 I appreciate you helping out! I already had a branch ready to go with this change, please see #98613

Thanks for contributing! If you would like to work on something else for the framework, but aren't sure where to start, let me know. I can suggest a few things. :)

@amanv8060

amanv8060 commented Feb 17, 2022

Copy link
Copy Markdown
Contributor Author

Sure @Piinks . Closing this.

@amanv8060 amanv8060 closed this Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@amanv8060 @Piinks