Skip to content

CupertinoActionSheet/CupertinoAlertDialog: Add clickable cursor for web - #99548

Merged
fluttergithubbot merged 2 commits into
flutter:masterfrom
NevercodeHQ:cupertino_dialog_sheet_web_cursor
Mar 28, 2022
Merged

CupertinoActionSheet/CupertinoAlertDialog: Add clickable cursor for web#99548
fluttergithubbot merged 2 commits into
flutter:masterfrom
NevercodeHQ:cupertino_dialog_sheet_web_cursor

Conversation

@TahaTesser

@TahaTesser TahaTesser commented Mar 4, 2022

Copy link
Copy Markdown
Contributor

part of #86174

Complete details #86174 (comment)

Integration test for web results:

CupertinoAlertDialog

Launching integration_test/cupertino/cupertino_alert_dialog.dart on Chrome in debug mode...
integration_test/cupertino/cupertino_alert_dialog.dart:1
DartUri: Unresolved uri: dart:web_sql
DartUri: Unresolved uri: dart:ui
This app is linked to the debug service: ws://127.0.0.1:51491/JQ62nlDzu78=/ws
Debug service listening on ws://127.0.0.1:51491/JQ62nlDzu78=/ws
💪 Running with sound null safety 💪
Connecting to VM Service at ws://127.0.0.1:51491/JQ62nlDzu78=/ws
00:00 +0: Hovering over Cupertino dialog action updates cursor to clickable on Web
00:00 +1: (tearDownAll)
00:00 +2: All tests passed!

CupertinoActionSheet

Launching integration_test/cupertino/cupertino_action_sheet.dart on Chrome in debug mode...
integration_test/cupertino/cupertino_action_sheet.dart:1
DartUri: Unresolved uri: dart:web_sql
DartUri: Unresolved uri: dart:ui

This app is linked to the debug service: ws://127.0.0.1:51702/ZOm9ms5kjP8=/ws
Debug service listening on ws://127.0.0.1:51702/ZOm9ms5kjP8=/ws
💪 Running with sound null safety 💪
Connecting to VM Service at ws://127.0.0.1:51702/ZOm9ms5kjP8=/ws
00:00 +0: Hovering over Cupertino action sheet action updates cursor to clickable on Web
00:00 +1: (tearDownAll)
00:00 +2: All tests passed!

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard Bot added p: cupertino_ui cupertino_ui package in flutter/packages framework flutter/packages/flutter repository. See also f: labels. labels Mar 4, 2022
@TahaTesser TahaTesser mentioned this pull request Mar 4, 2022
Closed
@TahaTesser
TahaTesser force-pushed the cupertino_dialog_sheet_web_cursor branch from 837c4ec to 55b7bfb Compare March 22, 2022 08:18
Renzo-Olivares
Renzo-Olivares approved these changes Mar 24, 2022
View reviewed changes

ghost left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for my delay. LGTM but looks like there's an unrelated analyzer issue. I think syncing up to master should clear that up. Thanks for this!

@TahaTesser
TahaTesser force-pushed the cupertino_dialog_sheet_web_cursor branch from 55b7bfb to b82f51f Compare March 25, 2022 08:02
@TahaTesser
TahaTesser force-pushed the cupertino_dialog_sheet_web_cursor branch from b82f51f to 690df29 Compare March 28, 2022 07:05
@fluttergithubbot
fluttergithubbot merged commit d2cb63c into flutter:master Mar 28, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 28, 2022
Merged
@TahaTesser
TahaTesser deleted the cupertino_dialog_sheet_web_cursor branch March 28, 2022 08:18
This was referenced Mar 29, 2022
Closed
Closed
Closed
Closed
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Renzo-Olivares Renzo-Olivares Renzo-Olivares approved these changes

Assignees

No one assigned

Labels

framework flutter/packages/flutter repository. See also f: labels. p: cupertino_ui cupertino_ui package in flutter/packages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TahaTesser @Renzo-Olivares @fluttergithubbot