Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/packages
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 258f6dce6a49
Choose a base ref
...
head repository: flutter/packages
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 02c6fef4ef63
Choose a head ref
  • 6 commits
  • 256 files changed
  • 5 contributors

Commits on Jan 27, 2025

  1. [shared_preferences] Fix Android type mismatch regression (#8512)

    `getStringList` should throw a `TypeError` if the stored value is of a
    different type, but the recent change to use JSON-encoded string lists
    regression that behavior if the stored type was a string, causing it to
    instead return null.
    
    This restores the previous behavior by passing extra information from
    Kotlin to Dart when attempting to get an enecoded string list, so that
    if a non-encoded-list string is found, a TypeError can be created on the
    Dart side.
    
    Since extra information is now being passed, the case of a
    legacy-encoded value is now communicated as well, so that we only have
    to request the legacy value if it's there, rather than always trying
    (which was not worth the complexity of adding extra data just for that
    initially, but now that we need extra data anyway, it's easy to
    distinguish that case).
    
    Fixes OOB regression in `shared_preferences` tests that has closed the
    tree.
    stuartmorgan-g authored Jan 27, 2025
    Configuration menu
    Copy the full SHA
    99f79d9 View commit details
    Browse the repository at this point in the history
  2. [multicast_dns] Rewrite _readFQDN to avoid recursion (#8390)

    Speculatively fixes flutter/flutter#155433. Read [one of my later comments](flutter/flutter#155433 (comment)) on that thread for my current understanding of this issue. In summary, this PR rewrites `_readFQDN` to avoid recursion.
    
    **For reviewers: For a simplified diff, see the first commit, [change](https://github.com/flutter/packages/commit/7afa1db54e07f024b2a4550d160b4d4a9f67f2c7).** This commit avoids formatting make sure the diff only highlights changes to logic rather than formatting.
    
    <details>
    
    <summary> Pre-launch Checklist </summary>
    
    - x ] I signed the [CLA].
    
    </details>
    andrewkolos authored Jan 27, 2025
    Configuration menu
    Copy the full SHA
    15d1e92 View commit details
    Browse the repository at this point in the history
  3. [video_player_platform_interface] Platform view support (#8453)

    This PR is a subset of #8237 - it only adds platform interface changes.
    
    Partially resolves [86613](flutter/flutter#86613).
    FirentisTFW authored Jan 27, 2025
    Configuration menu
    Copy the full SHA
    2165b5c View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2025

  1. update the const in StatefulShellRouteData generation (#8502)

    fixes:flutter/flutter#161305 
    also fix some typos: statefull* -> stateful*
    hannah-hyj authored Jan 28, 2025
    Configuration menu
    Copy the full SHA
    040f805 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d6705de View commit details
    Browse the repository at this point in the history
  3. Revert "[shared_preferences] Add shared preferences devtool" (#8515)

    Reverts #8494
    
    This is a revert in order to reland (as a revert of this revert) now that the out-of-band failure in shared preferences is resolved, so that the package can go through the CI release process to ensure that the new tooling for pre-publish builds is working correctly.
    stuartmorgan-g authored Jan 28, 2025
    Configuration menu
    Copy the full SHA
    02c6fef View commit details
    Browse the repository at this point in the history
Loading