Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/packages
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 27896d1c5aa8
Choose a base ref
...
head repository: flutter/packages
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: cc9ff470587b
Choose a head ref
  • 8 commits
  • 59 files changed
  • 6 contributors

Commits on Aug 1, 2024

  1. [shared_preferences] fix stringlist bug (#7268)

    I tested this a few different ways and there was never any savings by not casting when the list is already `List<String>`.
    
    fixes flutter/flutter#152607
    tarrinneal authored Aug 1, 2024
    Configuration menu
    Copy the full SHA
    897f329 View commit details
    Browse the repository at this point in the history
  2. [various] Clean up C++ formatting (#7272)

    Some C++ no-body constructors had stray `;`s after them, which cause weird formatting. This removes them all, which is purely a formatting change with no runtime implications.
    stuartmorgan-g authored Aug 1, 2024
    Configuration menu
    Copy the full SHA
    c3a911c View commit details
    Browse the repository at this point in the history
  3. Manual roll Flutter from f817e51 to e2e4398 (5 revisions) (#7276)

    Manual roll requested by [email protected]
    
    flutter/flutter@f817e51...e2e4398
    
    2024-07-29 [email protected] mark Mac tool_integration_tests_* as
    non-bringup (flutter/flutter#152412)
    2024-07-28 [email protected] Roll Flutter Engine from
    947bcb08a50f to 7f7ad741fefa (1 revision) (flutter/flutter#152454)
    2024-07-28 [email protected] Roll Flutter Engine from
    f0effaaf4001 to 947bcb08a50f (1 revision) (flutter/flutter#152449)
    2024-07-28 [email protected] Roll Flutter Engine from
    dfdb2d5f114a to f0effaaf4001 (1 revision) (flutter/flutter#152446)
    2024-07-27 [email protected] Roll Flutter Engine from
    add1b784b80a to dfdb2d5f114a (1 revision) (flutter/flutter#152440)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-packages
    Please CC [email protected],[email protected] on the revert to
    ensure that a human
    is aware of the problem.
    
    To file a bug in Packages:
    https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Aug 1, 2024
    Configuration menu
    Copy the full SHA
    945f514 View commit details
    Browse the repository at this point in the history
  4. [google_maps_flutter] Switch Android examples to TLHC (#7282)

    The Android example apps were still using HC mode, from when that was
    the recommended option due to lost updates with TLHC. Now that the
    README strongly recommends using TLHC rather than HC, we should reflect
    that in our examples.
    
    This is both a user-facing change, since it's what shows on pub.dev and
    we want to set the right example there, and also changes our test
    coverage. Ideally we would test both, and an issue will be filed to
    explore that, but for as long as we are only testing one it should be
    the recommended option.
    
    This came up in the context of investigating
    flutter/flutter#152691 where impeller on
    google maps when using hybrid composition caused a crash, and I think
    it's just an oversight that we hadn't changed this.
    
    ## Pre-launch Checklist
    
    - [x] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [x] I read the [Tree Hygiene] page, which explains my
    responsibilities.
    - [x] I read and followed the [relevant style guides] and ran the
    auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages
    repo does use `dart format`.)
    - [x] I signed the [CLA].
    - [x] The title of the PR starts with the name of the package surrounded
    by square brackets, e.g. `[shared_preferences]`
    - [x] I [linked to at least one issue that this PR fixes] in the
    description above.
    - [x] I updated `pubspec.yaml` with an appropriate new version according
    to the [pub versioning philosophy], or this PR is [exempt from version
    changes].
    - [x] I updated `CHANGELOG.md` to add a description of the change,
    [following repository CHANGELOG style], or this PR is [exempt from
    CHANGELOG changes].
    - [x] I updated/added relevant documentation (doc comments with `///`).
    - [x] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [x] All existing and new tests are passing.
    
    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/packages/blob/main/CONTRIBUTING.md
    [Tree Hygiene]:
    https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md
    [relevant style guides]:
    https://github.com/flutter/packages/blob/main/CONTRIBUTING.md#style
    [CLA]: https://cla.developers.google.com/
    [Discord]:
    https://github.com/flutter/flutter/blob/master/docs/contributing/Chat.md
    [linked to at least one issue that this PR fixes]:
    https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#overview
    [pub versioning philosophy]: https://dart.dev/tools/pub/versioning
    [exempt from version changes]:
    https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#version
    [following repository CHANGELOG style]:
    https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#changelog-style
    [exempt from CHANGELOG changes]:
    https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#changelog
    [test-exempt]:
    https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#tests
    stuartmorgan-g authored Aug 1, 2024
    Configuration menu
    Copy the full SHA
    1b9195b View commit details
    Browse the repository at this point in the history
  5. [go_router] Documentation for StatefulShellRoute (#6308)

    Adds documentation about StatefulShellRoute to the Configuration topic (configuration.md).
    
    Fixes flutter/flutter#127209.
    tolo authored Aug 1, 2024
    Configuration menu
    Copy the full SHA
    9cc06ac View commit details
    Browse the repository at this point in the history
  6. [web] Update package:web to ">=0.5.1 <2.0.0" (#7202)

    This PR updates packages that depend on `package:web` to `web: ">=0.5.1 <2.0.0"`.
    
    ## Issues
    
    * Fixes: flutter/flutter#151981
    ditman authored Aug 1, 2024
    Configuration menu
    Copy the full SHA
    1c4b286 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2024

  1. [ci] Re-enable google_maps_flutter_web integration tests. (#7269)

    Attempt to re-enable integration tests on the `google_maps_flutter_web` package, post-package:web migration, see what happens.
    
    Part of: #7087
    ditman authored Aug 2, 2024
    Configuration menu
    Copy the full SHA
    3ad6fb8 View commit details
    Browse the repository at this point in the history
  2. [tool] Add note about clang version used in CI to tool readme (#7273)

    This repo uses clang 15 to format files. Newer versions of clang format code differently. This PR adds a note to the tool README about this and adds sample instructions for how to install clang 15 on macOS. We might want to add instructions for other platforms.
    
    Fixes flutter/flutter#152651
    
    Additional context
    - #7267
    - #7271
    Rexios80 authored Aug 2, 2024
    Configuration menu
    Copy the full SHA
    cc9ff47 View commit details
    Browse the repository at this point in the history
Loading