Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/packages
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 4bf51144c295
Choose a base ref
...
head repository: flutter/packages
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 2faf992a0589
Choose a head ref
  • 7 commits
  • 18 files changed
  • 6 contributors

Commits on Oct 23, 2023

  1. [tool] Add optional swift-format support (#5204) 

    Adds support for swift-format in the `format` command. For now this is optional, so is only triggered if the flag is explictly passed. In the future, once we have CI support for swift-format, we will likely want to make it on-by-default as with the other formatters.

Part of flutter/flutter#41129
    @stuartmorgan-g
    stuartmorgan-g authored Oct 23, 2023
    Configuration menu
    Copy the full SHA
    e73b364 View commit details
    Browse the repository at this point in the history

  2. Roll Flutter from 823e083 to 5e8b5f4 (13 revisions) (#5208) 

    flutter/flutter@823e083...5e8b5f4

2023-10-23 [email protected] Update `ColorScheme.fromSwatch` docs for Material 3 (flutter/flutter#136816)
2023-10-23 [email protected] Reland "Fixes ability to call nextFocus() on a node to focus its descâ�¦ (flutter/flutter#136898)
2023-10-23 [email protected] `OverlayPortal.overlayChild` contributes semantics to `OverlayPortal` instead of `Overlay` (flutter/flutter#134921)
2023-10-23 [email protected] Roll Packages from be915be to 4bf5114 (12 revisions) (flutter/flutter#137062)
2023-10-23 [email protected] Roll Flutter Engine from 8820a419c800 to 1dc66e8f2fba (1 revision) (flutter/flutter#137055)
2023-10-23 [email protected] Roll Flutter Engine from e2abdeb650f8 to 8820a419c800 (1 revision) (flutter/flutter#137051)
2023-10-23 [email protected] Roll Flutter Engine from 39f78ce1884d to e2abdeb650f8 (1 revision) (flutter/flutter#137050)
2023-10-23 [email protected] Roll Flutter Engine from 4899344c34d9 to 39f78ce1884d (1 revision) (flutter/flutter#137048)
2023-10-23 [email protected] Roll Flutter Engine from 9d05b061e245 to 4899344c34d9 (1 revision) (flutter/flutter#137046)
2023-10-23 [email protected] Roll Flutter Engine from cde34b8182b1 to 9d05b061e245 (1 revision) (flutter/flutter#137044)
2023-10-22 [email protected] Add timeline events for post frame callbacks (flutter/flutter#136435)
2023-10-22 [email protected] Roll Flutter Engine from b8d702c0e0d7 to cde34b8182b1 (1 revision) (flutter/flutter#137038)
2023-10-22 [email protected] Roll Flutter Engine from f3c7a50bc83f to b8d702c0e0d7 (1 revision) (flutter/flutter#137035)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll authored Oct 23, 2023
    Configuration menu
    Copy the full SHA
    be5c798 View commit details
    Browse the repository at this point in the history

  3. [local_auth]: Bump androidx.fragment:fragment from 1.6.0 to 1.6.1 in … 

    …/packages/local_auth/local_auth_android/android (#4600)

Bumps androidx.fragment:fragment from 1.6.0 to 1.6.1.

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=androidx.fragment:fragment&package-manager=gradle&previous-version=1.6.0&new-version=1.6.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

You can trigger a rebase of this PR by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

> **Note**
> Automatic rebases have been disabled on this pull request as it has been open for over 30 days.
    @dependabot
    dependabot[bot] authored Oct 23, 2023
    Configuration menu
    Copy the full SHA
    a64da5c View commit details
    Browse the repository at this point in the history

  4. [url_launcher_web] Disallows launching "javascript:" URLs. (#5180) 

    This PR updates the URL launcher to:

* Implement the new `launchUrl` method.
* Disallow `launch` and `launchUrl` for URLs with the `javascript:` scheme. 
* Prevent _Tabnabbing_.

### Issues

Fixes flutter/flutter#136657

### Tests

Integration tests (and mocks) updated.
    @ditman
    ditman authored Oct 23, 2023
    Configuration menu
    Copy the full SHA
    5c6cb75 View commit details
    Browse the repository at this point in the history

  5. [ci] Remove device_type property from Windows Arm64 properties (#5193) 

    The Windows Arm64 tests are failing to start as no machines match desired properties. This removes the `device_type: none` property as no Windows Arm64 machines match this ([with `device_type`](https://chromium-swarm.appspot.com/botlist?c=id&c=task&c=os&c=status&d=asc&f=cpu%3Aarm64&f=os%3AWindows&f=pool%3Aluci.flutter.staging&f=device_type%3Anone&s=id), [without `device_type`](https://chromium-swarm.appspot.com/botlist?c=id&c=task&c=os&c=status&d=asc&f=cpu%3Aarm64&f=os%3AWindows&f=pool%3Aluci.flutter.staging&s=id)).

This matches the corresponding framework `.ci.yaml` platform properties, which also omits the `device_type: none` for Windows Arm64: https://github.com/flutter/flutter/blob/997a94fd1f022492b6c955013eeec7e4c4e67c62/.ci.yaml#L192-L209

Part of flutter/flutter#129813
    @loic-sharma
    loic-sharma authored Oct 23, 2023
    Configuration menu
    Copy the full SHA
    30b1094 View commit details
    Browse the repository at this point in the history

  6. [url_launcher] Add an inAppBrowserView mode (#5205) 

    Platform interface portion of #5155. Adds the `inAppBrowserView` launch mode, as well as the `supportsMode` and `supportsCloseForMode` support query APIs.
    @stuartmorgan-g
    stuartmorgan-g authored Oct 23, 2023
    Configuration menu
    Copy the full SHA
    d5053b5 View commit details
    Browse the repository at this point in the history

  7. Change firebase device tests from Android api 30 to 33 (#5185) 

    Changes firebase device tests to use android 13. I know there is consideration [for turning them off](flutter/flutter#131429), but as long as we are running them we may as well run them on as new an android version as we can (I'm assuming here we can't use android 14 due to the [ongoing work](#4974) to fix some tests on android 14).

The particular device is listed as high capacity. The list can be seen here in the 3rd option without any login https://firebase.google.com/docs/test-lab/android/available-testing-devices
    @gmackall
    gmackall authored Oct 23, 2023
    Configuration menu
    Copy the full SHA
    2faf992 View commit details
    Browse the repository at this point in the history
Loading