Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/packages
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 6698b2d67999
Choose a base ref
...
head repository: flutter/packages
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 90c876d37619
Choose a head ref
  • 7 commits
  • 22 files changed
  • 7 contributors

Commits on Apr 15, 2024

  1. Update local_auth_android minSdkVersion to 19 (#6537)

    #6506 was supposed to update everything to 19+, but missed local_auth_android. This updates it to require 19 as well.
    stuartmorgan-g authored Apr 15, 2024
    Configuration menu
    Copy the full SHA
    365d675 View commit details
    Browse the repository at this point in the history
  2. Manual roll Flutter from 53cba24 to 2e748e8 (19 revisions) (#6541)

    Manual roll requested by [email protected]
    
    flutter/flutter@53cba24...2e748e8
    
    2024-04-15 [email protected] Implementing control flow collections (flutter/flutter#146601)
    2024-04-15 [email protected] Roll Packages from 78f684c to 6698b2d (3 revisions) (flutter/flutter#146761)
    2024-04-15 [email protected] test: Fix memory leak in transitions test (flutter/flutter#146747)
    2024-04-15 [email protected] Fix filled text field active indicator overflows container bounds (flutter/flutter#146637)
    2024-04-14 [email protected] - Fixes _DropdownMenuState leaking text controller (flutter/flutter#146571)
    2024-04-13 [email protected] Fix memory leaks in `FloatingActionButton` (flutter/flutter#146711)
    2024-04-12 [email protected] Roll Flutter Engine from 0e56e3dffe43 to 1a13c7d1f40e (2 revisions) (flutter/flutter#146703)
    2024-04-12 [email protected] Roll pub packages (flutter/flutter#146704)
    2024-04-12 49699333+dependabot[bot]@users.noreply.github.com Bump peter-evans/create-pull-request from 6.0.2 to 6.0.3 (flutter/flutter#146702)
    2024-04-12 [email protected] Avoid forwarding the data after socket is disconnected. (flutter/flutter#146665)
    2024-04-12 [email protected] [flutter_tools] Fix conductor for package args roll (flutter/flutter#146646)
    2024-04-12 [email protected] Roll Flutter Engine from 6b37b170998e to 0e56e3dffe43 (4 revisions) (flutter/flutter#146698)
    2024-04-12 [email protected] Light sliver clean up before SliverTree (flutter/flutter#146696)
    2024-04-12 [email protected] Fix label text color is wrong for a focused and hovered TextField (flutter/flutter#146572)
    2024-04-12 [email protected] Fix `getOffsetForCaret` crash (flutter/flutter#146669)
    2024-04-12 [email protected] Update gen_keycodes templates (flutter/flutter#146481)
    2024-04-12 [email protected] Support `flutter run --wasm` and `flutter drive --wasm`. (flutter/flutter#146231)
    2024-04-12 [email protected] Fix curved animation memory leak for scrollbar (flutter/flutter#146670)
    2024-04-12 [email protected] Roll Packages from e98839a to 78f684c (6 revisions) (flutter/flutter#146691)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-packages
    Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Apr 15, 2024
    Configuration menu
    Copy the full SHA
    6116ae5 View commit details
    Browse the repository at this point in the history
  3. [url_launcher][web] Link should work when triggered by keyboard (#6505)

    ### Background
    
    You can think of the `Link` widget (on the web) as two components working together:
    
    1. The `<a>` element created by the `Link` widget. This is essential to make all browser interactions feel natural (e.g. context menu, cmd+click, etc).
    2. The children of `Link` widget. These are the widgets visible to the user (e.g. a button or a hyperlink text) and the user can interact with them the same way they would interact with any Flutter widgets (focus, pointer click, etc).
    
    In order for the Link widget to navigate to a URI, the two components from above have to indicate their intent of navigation:
    
    1. Some widget has to call `followLink` to indicate that the click successfully landed (i.e. hit tested) on it. E.g. if it's a button, then the `onPressed` callback should lead to a call to the Link's `followLink`.
    2. The `<a>` element also has to receive an event to initiate the navigation.
    
    ### The PR
    
    We used to only handle click events on the `<a>` element, and no handling for keyboard events was present. So when a user tabs their way to the Link, then hits "Enter", the following happens:
    
    1. The focused widget (e.g. button) that received the "Enter" will correctly indicate its intent to navigate by calling `followLink`.
    2. The intent from the `<a>` element is lost because we were only handling clicks and not keyboard events.
    
    This PR adds handling of keyboard events so that it works similar to clicks.
    
    Fixes flutter/flutter#97863
    mdebbar authored Apr 15, 2024
    Configuration menu
    Copy the full SHA
    1d0bb4f View commit details
    Browse the repository at this point in the history
  4. [image_picker] Adopt code excerpts in README (#5523)

    Improves image_picker_for_web README example and updates it to use code excerpts.
    
    Part of [flutter/flutter#102679](flutter/flutter#102679)
    mike-v2 authored Apr 15, 2024
    Configuration menu
    Copy the full SHA
    9a24904 View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2024

  1. [video_player] Calls onDestroy instead of initialize in onDetache…

    …dFromEngine (#6501)
    
    In the `onDetachedFromEngine` function, the `onDestroy` method should be called instead of the `initialize` method, even though the implementation of the two functions is no different.
    
    ```java
      private void onDestroy() {
        // The whole FlutterView is being destroyed. Here we release resources acquired for all
        // instances
        // of VideoPlayer. Once flutter/flutter#19358 is resolved this may
        // be replaced with just asserting that videoPlayers.isEmpty().
        // flutter/flutter#20989 tracks this.
        disposeAllPlayers();
      }
    
      public void initialize() {
        disposeAllPlayers();
      }
    ```
    0xZOne authored Apr 16, 2024
    Configuration menu
    Copy the full SHA
    b2bd8e5 View commit details
    Browse the repository at this point in the history
  2. [CupertinoIcons] fix broken icons and vertical alignment, bump the ve…

    …rsion to 1.08 (#6520)
    
    See this PR for the font change: xster/framework7-icons#2
    LongCatIsLooong authored Apr 16, 2024
    Configuration menu
    Copy the full SHA
    701d60a View commit details
    Browse the repository at this point in the history
  3. Bump github/codeql-action from 3.24.10 to 3.25.0 (#6545)

    Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.24.10 to 3.25.0.
    <details>
    <summary>Changelog</summary>
    <p><em>Sourced from <a href="https://github.com/github/codeql-action/blob/main/CHANGELOG.md">github/codeql-action's changelog</a>.</em></p>
    <blockquote>
    <h1>CodeQL Action Changelog</h1>
    <p>See the <a href="https://github.com/github/codeql-action/releases">releases page</a> for the relevant changes to the CodeQL CLI and language packs.</p>
    <p>Note that the only difference between <code>v2</code> and <code>v3</code> of the CodeQL Action is the node version they support, with <code>v3</code> running on node 20 while we continue to release <code>v2</code> to support running on node 16. For example <code>3.22.11</code> was the first <code>v3</code> release and is functionally identical to <code>2.22.11</code>. This approach ensures an easy way to track exactly which features are included in different versions, indicated by the minor and patch version numbers.</p>
    <h2>[UNRELEASED]</h2>
    <p>No user facing changes.</p>
    <h2>3.25.0 - 15 Apr 2024</h2>
    <ul>
    <li>
    <p>The deprecated feature for extracting dependencies for a Python analysis has been removed. <a href="https://redirect.github.com/github/codeql-action/pull/2224">#2224</a></p>
    <p>As a result, the following inputs and environment variables are now ignored:</p>
    <ul>
    <li>The <code>setup-python-dependencies</code> input to the <code>init</code> Action</li>
    <li>The <code>CODEQL_ACTION_DISABLE_PYTHON_DEPENDENCY_INSTALLATION</code> environment variable</li>
    </ul>
    <p>We recommend removing any references to these from your workflows. For more information, see the release notes for CodeQL Action v3.23.0 and v2.23.0.</p>
    </li>
    <li>
    <p>Automatically overwrite an existing database if found on the filesystem. <a href="https://redirect.github.com/github/codeql-action/pull/2229">#2229</a></p>
    </li>
    <li>
    <p>Bump the minimum CodeQL bundle version to 2.12.6. <a href="https://redirect.github.com/github/codeql-action/pull/2232">#2232</a></p>
    </li>
    <li>
    <p>A more relevant log message and a diagnostic are now emitted when the <code>file</code> program is not installed on a Linux runner, but is required for Go tracing to succeed. <a href="https://redirect.github.com/github/codeql-action/pull/2234">#2234</a></p>
    </li>
    </ul>
    <h2>3.24.10 - 05 Apr 2024</h2>
    <ul>
    <li>Update default CodeQL bundle version to 2.17.0. <a href="https://redirect.github.com/github/codeql-action/pull/2219">#2219</a></li>
    <li>Add a deprecation warning for customers using CodeQL version 2.12.5 and earlier. These versions of CodeQL were discontinued on 26 March 2024 alongside GitHub Enterprise Server 3.8, and will be unsupported by CodeQL Action versions 3.25.0 and later and versions 2.25.0 and later. <a href="https://redirect.github.com/github/codeql-action/pull/2220">#2220</a>
    <ul>
    <li>If you are using one of these versions, please update to CodeQL CLI version 2.12.6 or later. For instance, if you have specified a custom version of the CLI using the 'tools' input to the 'init' Action, you can remove this input to use the default version.</li>
    <li>Alternatively, if you want to continue using a version of the CodeQL CLI between 2.11.6 and 2.12.5, you can replace <code>github/codeql-action/*@V3</code> by <code>github/codeql-action/*@v3.24.10</code> and <code>github/codeql-action/*@v2</code> by <code>github/codeql-action/*@v2.24.10</code> in your code scanning workflow to ensure you continue using this version of the CodeQL Action.</li>
    </ul>
    </li>
    </ul>
    <h2>3.24.9 - 22 Mar 2024</h2>
    <ul>
    <li>Update default CodeQL bundle version to 2.16.5. <a href="https://redirect.github.com/github/codeql-action/pull/2203">#2203</a></li>
    </ul>
    <h2>3.24.8 - 18 Mar 2024</h2>
    <ul>
    <li>Improve the ease of debugging extraction issues by increasing the verbosity of the extractor logs when running in debug mode. <a href="https://redirect.github.com/github/codeql-action/pull/2195">#2195</a></li>
    </ul>
    <h2>3.24.7 - 12 Mar 2024</h2>
    <ul>
    <li>Update default CodeQL bundle version to 2.16.4. <a href="https://redirect.github.com/github/codeql-action/pull/2185">#2185</a></li>
    </ul>
    <h2>3.24.6 - 29 Feb 2024</h2>
    <p>No user facing changes.</p>
    <h2>3.24.5 - 23 Feb 2024</h2>
    <ul>
    <li>Update default CodeQL bundle version to 2.16.3. <a href="https://redirect.github.com/github/codeql-action/pull/2156">#2156</a></li>
    </ul>
    </blockquote>
    <p>... (truncated)</p>
    </details>
    <details>
    <summary>Commits</summary>
    <ul>
    <li><a href="https://github.com/github/codeql-action/commit/df5a14dc28094dc936e103b37d749c6628682b60"><code>df5a14d</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2238">#2238</a> from github/update-v3.25.0-2b2cee522</li>
    <li><a href="https://github.com/github/codeql-action/commit/3f70eaa4d31bbf0600be93a0ae88db6c0aef186a"><code>3f70eaa</code></a> Update changelog for v3.25.0</li>
    <li><a href="https://github.com/github/codeql-action/commit/2b2cee52294c410df28cc7ba0beaf429d5b4e82c"><code>2b2cee5</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2234">#2234</a> from github/mbg/clearer-file-command-failure</li>
    <li><a href="https://github.com/github/codeql-action/commit/4fcf7a216ce13f13ffe9f395a802a3f22f8190e6"><code>4fcf7a2</code></a> Add changelog entry</li>
    <li><a href="https://github.com/github/codeql-action/commit/d30d1cabb492838711c91e6280899193c0f779c7"><code>d30d1ca</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2237">#2237</a> from github/henrymercer/more-configuration-errors</li>
    <li><a href="https://github.com/github/codeql-action/commit/55585360a353847d36f63bc5c29f1b7086340901"><code>5558536</code></a> Add configuration error for unsupported build mode</li>
    <li><a href="https://github.com/github/codeql-action/commit/fa75c144b4edca3ccd9a781733939fad7515f12e"><code>fa75c14</code></a> Capture rate limit and ref not existing config errors</li>
    <li><a href="https://github.com/github/codeql-action/commit/5a599c68cf43195b46783a38eafaca73404ea2e4"><code>5a599c6</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2236">#2236</a> from github/henrymercer/feature-flags-with-tool-feat...</li>
    <li><a href="https://github.com/github/codeql-action/commit/829376a61898ee2e4be42297fc41c4adcc10bf00"><code>829376a</code></a> Allow feature flags to specify tool feature requirements</li>
    <li><a href="https://github.com/github/codeql-action/commit/efc474680fa70a6df5c97b97233f665b4b7d6749"><code>efc4746</code></a> Downgrade log levels for some messages to debug</li>
    <li>Additional commits viewable in <a href="https://github.com/github/codeql-action/compare/4355270be187e1b672a7a1c7c7bae5afdc1ab94a...df5a14dc28094dc936e103b37d749c6628682b60">compare view</a></li>
    </ul>
    </details>
    <br />
    
    [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github/codeql-action&package-manager=github_actions&previous-version=3.24.10&new-version=3.25.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
    
    Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
    
    ---
    
    <details>
    <summary>Dependabot commands and options</summary>
    <br />
    
    You can trigger Dependabot actions by commenting on this PR:
    - `@dependabot rebase` will rebase this PR
    - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
    - `@dependabot merge` will merge this PR after your CI passes on it
    - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
    - `@dependabot cancel merge` will cancel a previously requested merge and block automerging
    - `@dependabot reopen` will reopen this PR if it is closed
    - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
    - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
    - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
    - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
    - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    
    </details>
    dependabot[bot] authored Apr 16, 2024
    Configuration menu
    Copy the full SHA
    90c876d View commit details
    Browse the repository at this point in the history
Loading