Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/packages
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 8de142d33b88
Choose a base ref
...
head repository: flutter/packages
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 6c4482a64492
Choose a head ref
  • 8 commits
  • 70 files changed
  • 5 contributors

Commits on May 8, 2024

  1. [ios_platform_images] Add Swift Package Manager support (#6684)

    Adds Swift Package Manager support to `ios_platform_images`.
    
    This does not migrate the example app's Xcode project; the example app's Xcode project is migrated whenever you run it using the Flutter tool with the Swift Package Manager feature enabled.
    
    Fixes flutter/flutter#146909
    loic-sharma authored May 8, 2024
    Configuration menu
    Copy the full SHA
    0167b51 View commit details
    Browse the repository at this point in the history
  2. [video_player_avfoundation] Adds Swift Package Manager compatibility (#…

    …6675)
    
    Makes `video_player_avfoundation` available as a Swift Package to Flutter. Also, remains compatible with CocoaPods.
    
    Fixes flutter/flutter#146921.
    
    Redo of #6634.
    vashworth authored May 8, 2024
    Configuration menu
    Copy the full SHA
    09a373f View commit details
    Browse the repository at this point in the history
  3. [image_picker_ios] Adds Swift Package Manager compatibility to image_…

    …picker_ios (#6617)
    
    Makes `image_picker_ios` available as a Swift Package to Flutter. Also, remains compatible with CocoaPods.
    
    Fixes flutter/flutter#146919.
    vashworth authored May 8, 2024
    Configuration menu
    Copy the full SHA
    a444af5 View commit details
    Browse the repository at this point in the history
  4. Reverts "[image_picker_ios] Adds Swift Package Manager compatibility …

    …to image_picker_ios (#6617)" (#6693)
    
    Reverts: #6617
    Initiated by: vashworth
    Reason for reverting: Failing [Mac_arm64 ios_platform_tests_shard_1 master](https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_arm64%20ios_platform_tests_shard_1%20master/1942/overview)
    
    Original PR Author: vashworth
    
    Reviewed By: {loic-sharma, stuartmorgan}
    
    This change reverts the following previous change:
    Makes `image_picker_ios` available as a Swift Package to Flutter. Also, remains compatible with CocoaPods.
    
    Fixes flutter/flutter#146919.
    auto-submit[bot] authored May 8, 2024
    Configuration menu
    Copy the full SHA
    a9f14bc View commit details
    Browse the repository at this point in the history
  5. Temporarily add empty header files to video_player_avfoundation so in…

    …clude directory is downloaded (#6694)
    
    Fixes flutter/flutter#148003.
    
    Temporary solution to make tree green.
    vashworth authored May 8, 2024
    Configuration menu
    Copy the full SHA
    d670b2c View commit details
    Browse the repository at this point in the history

Commits on May 9, 2024

  1. [pointer_interceptor] Remove implements from app-facing package (#6699

    )
    
    Dart unit tests started failing for `pointer_interceptor` due to the `implements` tag in the app facing package. This plugin is federated for ios and web, so it looks like the error message is valid.
    
    ```
    Plugin pointer_interceptor:ios provides an implementation for pointer_interceptor_platform_interface and also references a default implementation for pointer_interceptor_ios, which is currently not supported. Ask the maintainers of pointer_interceptor to either remove the implementation via `implements: pointer_interceptor_platform_interface` or avoid referencing a default implementation via `platforms: ios: default_package: pointer_interceptor_ios`.
    
    00:00 +0 -1: loading /b/s/w/ir/x/w/packages/packages/pointer_interceptor/pointer_interceptor/test/tests_exist_elsewhere_test.dart [E]                                                                  
      Error: Please resolve the plugin pubspec errors
      package:flutter_tools/src/base/common.dart 10:3          throwToolExit
      package:flutter_tools/src/flutter_plugins.dart 1214:5    resolvePlatformImplementation
      package:flutter_tools/src/flutter_plugins.dart 1418:55   generateMainDartWithPluginRegistrant
      ===== asynchronous gap ===========================
      package:flutter_tools/src/test/test_compiler.dart 163:9  TestCompiler._onCompilationRequest
      
      TimeoutException after 0:12:00.000000: Test timed out after 12 minutes.
      package:test_api/src/backend/invoker.dart 338:28  Invoker._handleError.<fn>
      dart:async/zone.dart 1391:47                      _rootRun
      dart:async/zone.dart 1301:19                      _CustomZone.run
      package:test_api/src/backend/invoker.dart 336:10  Invoker._handleError
      package:test_api/src/backend/invoker.dart 291:9   Invoker.heartbeat.<fn>.<fn>
      dart:async/zone.dart 1399:13                      _rootRun
      dart:async/zone.dart 1301:19                      _CustomZone.run
      package:test_api/src/backend/invoker.dart 290:38  Invoker.heartbeat.<fn>
      dart:async-patch/timer_patch.dart 18:15           Timer._createTimer.<fn>
      dart:isolate-patch/timer_impl.dart 398:19         _Timer._runTimers
      dart:isolate-patch/timer_impl.dart 429:5          _Timer._handleMessage
      dart:isolate-patch/isolate_patch.dart 184:12      _RawReceivePort._handleMessage
      
    To run this test again: /b/s/w/ir/x/w/flutter/bin/cache/dart-sdk/bin/dart test 
    ```
    
    This removes the tag and does a manual roll.
    bparrishMines authored May 9, 2024
    Configuration menu
    Copy the full SHA
    4e79678 View commit details
    Browse the repository at this point in the history
  2. [flutter_lints] Rev to 4.0.0; prepare for publishing (#6695)

    To be submitted after dart-archive/lints#184 is published.
    goderbauer authored May 9, 2024
    Configuration menu
    Copy the full SHA
    4799c49 View commit details
    Browse the repository at this point in the history
  3. [image_picker_ios] Adds Swift Package Manager compatibility (#6696)

    Relands #6617.
    
    Was reverted in hopes of fixing flutter/flutter#148003, but ended up being fixed by #6694.
    vashworth authored May 9, 2024
    Configuration menu
    Copy the full SHA
    6c4482a View commit details
    Browse the repository at this point in the history
Loading