Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/packages
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: ab44c26de098
Choose a base ref
...
head repository: flutter/packages
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 7814fabbfb7a
Choose a head ref
  • 4 commits
  • 19 files changed
  • 4 contributors

Commits on May 8, 2025

  1. [camera_android_camerax] Fix camera preview rotation for landscape or… 

    …iented devices (#9097)

Fixes the incorrect camera preview rotation on landscape-oriented devices (like some tablets). Really, this PR generalizes the fix added in #8629 for correcting the camera preview rotation by correcting the camera preview rotation according to the rotation from the natural device orientation instead of assuming the device is naturally oriented in portrait up.

There are technically two different fixes in this PR; here's the breakdown for clarity:

1. For devices using the `SurfaceTexture` Impeller backend: Rotate the camera preview according to the current default display rotation (the rotation away from the natural device orientation) and ignore rotation added in `CameraPreview` widget completely (as it assumes the natural device orientation to be portrait up).
2. For devices using the `ImageReader` Impeller backend: Rotate the camera preview according to https://developer.android.com/media/camera/camera2/camera-preview#orientation_calculation, where `deviceOrientationDegrees` comes from [a call](https://developer.android.com/reference/android/view/Display?_gl=1*lysjx*_up*MQ..*_ga*NjY3Nzk0Mzg2LjE3NDU5NjY3ODc.*_ga_6HH9YJMN9M*MTc0NTk2Njc4Ni4xLjAuMTc0NTk2Njc4Ni4wLjAuMjEwMTI3NTg1Mg..#getRotation()) to get the current default display rotation (the rotation away from the natural device orientation) instead of assuming it to be the rotation degrees from portrait up.

Also, fixes a potential regression that @bparrishMines discovered in the `DeviceOrientationManager`. The changes there essentially ensure that it resets its state every time it is "re-started" to listen into changes into device orientation changes.

Fixes flutter/flutter#164493

*Seems to work on all physical devices I test, but not emulators (tried Pixel Tablet API 28, 35). I think that is an emulator bug? Otherwise tested on a new Pixel Tablet (API 34), Pixel Tablet C (API 12), Pixel 3A (phone, API 32).

## Pre-Review Checklist

[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
    @camsim99
    camsim99 authored May 8, 2025
    Configuration menu
    Copy the full SHA
    cfdb2ec View commit details
    Browse the repository at this point in the history

  2. Roll Flutter from b0f5c8c to 02d8c1a (19 revisions) (#9230) 

    flutter/flutter@b0f5c8c...02d8c1a

2025-05-08 [email protected] iOS,macOS: Unify iOS,macOS build configs (flutter/flutter#168517)
2025-05-08 [email protected] Roll Packages from b2ce3b0 to ab44c26 (3 revisions) (flutter/flutter#168548)
2025-05-08 [email protected] Remove unnecessary setAriaRole('dialog') fallback in SemanticRoute class (flutter/flutter#168345)
2025-05-08 [email protected] Roll Skia from 4d617bb1bb7d to 43ae814d2d95 (1 revision) (flutter/flutter#168526)
2025-05-08 [email protected] Roll Fuchsia Linux SDK from _GJje-N2Jk51qtBs6... to mqhX1OP8ezmialgqA... (flutter/flutter#168525)
2025-05-08 [email protected] Make MergeSemantics be able to merge customAction (flutter/flutter#168414)
2025-05-08 [email protected] Roll Skia from d787c26f873a to 4d617bb1bb7d (1 revision) (flutter/flutter#168514)
2025-05-08 [email protected] Roll pub packages (flutter/flutter#168509)
2025-05-07 [email protected] Marks Mac_arm64_ios imitation_game_swiftui to be unflaky (flutter/flutter#163114)
2025-05-07 [email protected] Add option to hide trailing icon in DropdownMenu (flutter/flutter#167782)
2025-05-07 [email protected] Roll Skia from 1ea3ec8e7863 to d787c26f873a (6 revisions) (flutter/flutter#168505)
2025-05-07 [email protected] [web] drop more use of deprecated JS functions (flutter/flutter#166157)
2025-05-07 [email protected] docs: Fixed broken links in WidgetStateProperty documentations (flutter/flutter#168191)
2025-05-07 [email protected] Roll Skia from 14f3e3209b73 to 1ea3ec8e7863 (2 revisions) (flutter/flutter#168489)
2025-05-07 [email protected] Use `config: enable-swift-...: false`, remove `disable-swift-...: true`. (flutter/flutter#168433)
2025-05-07 [email protected] Replace MediaQuery.sizeOf with heightOf and widthOf. (flutter/flutter#168479)
2025-05-07 [email protected] Fix stencil buffer leak (flutter/flutter#168448)
2025-05-07 [email protected] Fix framebuffer leak rendering to secondary views. (flutter/flutter#168447)
2025-05-07 [email protected] Fix uninitalized fields in FlutterWindowMetricsEvent (flutter/flutter#168446)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll authored May 8, 2025
    Configuration menu
    Copy the full SHA
    b270eae View commit details
    Browse the repository at this point in the history

  3. [go_router_builder] Fixes an deprecated warning for using withNullabi… 

    …lity (#9158)

*List which issues are fixed by this PR. You must list at least one issue.*
[Issue #166603](flutter/flutter#166603)

## Pre-Review Checklist
    @raju-muliyashiya
    raju-muliyashiya authored May 8, 2025
    Configuration menu
    Copy the full SHA
    1578d70 View commit details
    Browse the repository at this point in the history

  4. [go_router] Fix requestFocus propagation to Navigator (#9177) 

    Fixes [166972](flutter/flutter#166972)

## Pre-Review Checklist

[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
    @KevynSM
    KevynSM authored May 8, 2025
    Configuration menu
    Copy the full SHA
    7814fab View commit details
    Browse the repository at this point in the history
Loading