Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/packages
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: d062181ac465
Choose a base ref
...
head repository: flutter/packages
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 835dccb08f2e
Choose a head ref
  • 7 commits
  • 198 files changed
  • 6 contributors

Commits on Oct 13, 2025

  1. [pigeon] Fixes support for Kotlin/Java classes that override equals a…

    …nd hashCode for ProxyApis (#10039)
    
    ProxyApis for classes that override `equals()/hashcode` in Kotlin/Java were breaking the `InstanceManager`.
    
    The Kotlin `InstanceManager` would:
    1. Return true for `containsInstance`.
    2. Then remove the strong reference to the original object in `getIdentifierForStrongReference`. 
    3. Erroneously trigger the call to Dart to remove the strong reference of an instance.
    
    This changes the the use of `WeakReference` to a new `IdentityWeakReference` that uses identity to check for equality. Java/Kotlin has an `IdentityHashMap` and a `WeakHashMap`, but not an `IdentityWeakHashMap`. So this is a quick workaround to create an equivalent.
    
    Alternatively, `getIdentifierForStrongReference` could be updated to check `containsInstance` first, but this would leave small timeframes where objects would only have a weak reference. And it seems possible that Kotlin GC could cleanup at any moment. 
    
    Potential fix for flutter/flutter#174134 since the class they were creating a ProxyApi for was a data class: https://github.com/JavesonYehudi/proxy_bug_report/blob/main/android/src/main/kotlin/com/example/proxy_bug_report/auth/Credentials.kt
    
    ## Pre-Review Checklist
    
    **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.
    
    [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
    bparrishMines authored Oct 13, 2025
    Configuration menu
    Copy the full SHA
    79c5239 View commit details
    Browse the repository at this point in the history
  2. [dependabot]: Bump com.google.ads.interactivemedia.v3:interactivemedi…

    …a from 3.36.0 to 3.37.0 in /packages/interactive_media_ads/android (#10113)
    
    Bumps com.google.ads.interactivemedia.v3:interactivemedia from 3.36.0 to 3.37.0.
    
    [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=com.google.ads.interactivemedia.v3:interactivemedia&package-manager=gradle&previous-version=3.36.0&new-version=3.37.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
    
    Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
    
    ---
    
    <details>
    <summary>Dependabot commands and options</summary>
    <br />
    
    You can trigger Dependabot actions by commenting on this PR:
    - `@dependabot rebase` will rebase this PR
    - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
    - `@dependabot merge` will merge this PR after your CI passes on it
    - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
    - `@dependabot cancel merge` will cancel a previously requested merge and block automerging
    - `@dependabot reopen` will reopen this PR if it is closed
    - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
    - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
    - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
    - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
    - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    
    </details>
    dependabot[bot] authored Oct 13, 2025
    Configuration menu
    Copy the full SHA
    ca860ea View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2025

  1. [Many] Migrate non examples (and pigeon test) to java 17 (#10201)

    Fixes flutter/flutter/issues/176027 
    
    - **Update tooling to enforce java 17 compile options and kotlinOptions**
    - **Update interactive_media_ads and camera_android**
    - **Update compileOptions to java 17**
    - **Update changelog and pubspec for modified packages**
    - **Fix pigeon example**
    
    ## Pre-Review Checklist
    reidbaker authored Oct 14, 2025
    Configuration menu
    Copy the full SHA
    1c0be20 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2025

  1. [go_router] feat: access GoRouter.of from redirect methods (#9706)

    This PR fixes being able to access the GoRouter instance from the context inside redirect methods.
    
    It solves flutter/flutter#116855 (comment)
    
    My use case for this is:
    
    I'm building an extension package for navigation guards for `go_router`. Specifically, for type-safe generated routes. These guards are chainable and need to have the ability to block a route push/go. For this, I have the following method implemented:
    
    ```dart
      /// Block navigation by redirecting to current location
      void block({bool reevaluateOnChange = false}) {
        if (isResolved) return;
        final currentLocation =
            GoRouter.of(context).routerDelegate.currentConfiguration.fullPath;
        // Block by redirecting to current location
        _completer.complete(GuardResult.redirect(
          currentLocation,
          reevaluateOnChange: reevaluateOnChange,
        ));
      }
    ```
    
    This method, however, needs this PR because it's ran on the redirect function of a GoRouteData.
    
    ## Pre-Review Checklist
    
    **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.
    
    [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
    tomassasovsky authored Oct 15, 2025
    Configuration menu
    Copy the full SHA
    9084aeb View commit details
    Browse the repository at this point in the history
  2. Manual roll Flutter from e11e2c1 to 7cd821c (73 revisions) (#10229)

    Manual roll Flutter from e11e2c1 to 7cd821c (73 revisions)
    
    Manual roll requested by [email protected]
    
    flutter/flutter@e11e2c1...7cd821c
    
    2025-10-14 [email protected] Fix computeDistanceToActualBaseline throws when accessing child size (flutter/flutter#176906)
    2025-10-14 [email protected] iOS can set application locale before view controller is set (flutter/flutter#176592)
    2025-10-14 [email protected] Roll ANGLE to a branch based on d9fa255a5c22 (flutter/flutter#176747)
    2025-10-14 [email protected] Relands "Fixes keyboard selects disabled radio" (flutter/flutter#176977)
    2025-10-14 [email protected] Fix expansion tile is missing state announcement on non-Apple platforms (flutter/flutter#175480)
    2025-10-14 [email protected] impeller: allows access of float uniforms by name (flutter/flutter#176728)
    2025-10-14 [email protected] Roll dart sdk to 3.11.0-17.0.dev (flutter/flutter#176947)
    2025-10-13 [email protected] Move iOS integration tests (flutter/flutter#176940)
    2025-10-13 [email protected] Make sure that an InputDatePickerFormField doesn't crash in 0x0 envir… (flutter/flutter#176047)
    2025-10-13 [email protected] [web] Match the behavior of other platforms in Web Locale.toString if the country code is an empty string (flutter/flutter#176862)
    2025-10-13 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fixes keyboard selects disabled radio (#176727)" (flutter/flutter#176958)
    2025-10-13 [email protected] Fixes keyboard selects disabled radio (flutter/flutter#176727)
    2025-10-13 [email protected] Roll Packages from e319c40 to d062181 (2 revisions) (flutter/flutter#176916)
    2025-10-13 [email protected] Roll SwiftShader to 794b0cfce1d8 (flutter/flutter#176806)
    2025-10-13 [email protected] Make DropdownMenu generic type non nullable (flutter/flutter#176711)
    2025-10-12 [email protected] Roll Fuchsia Linux SDK from BWGpRvpdQh-HJpq1c... to _dd0Jv50H0oUI2Ad8... (flutter/flutter#176895)
    2025-10-11 [email protected] Roll Fuchsia Linux SDK from JpiUsek1hU5r9QVKP... to BWGpRvpdQh-HJpq1c... (flutter/flutter#176880)
    2025-10-11 [email protected] fix: content hash check for LUCI_CONTEXT (flutter/flutter#176867)
    2025-10-11 [email protected] Feat: make tooltip position customizeable (flutter/flutter#175047)
    2025-10-11 [email protected] Roll Dart SDK from d88d8bf2b53c to 65b171958c93 (3 revisions) (flutter/flutter#176871)
    2025-10-11 [email protected] feat: apply radioGroup role to segmented control widgets (flutter/flutter#176157)
    2025-10-10 [email protected] Make sure that a CheckboxMenuButton doesn't crash in 0x0 environment (flutter/flutter#176450)
    2025-10-10 [email protected] [WebParagraph] Support for more styles, placeholders, decorations, etc (flutter/flutter#172853)
    2025-10-10 [email protected] Set up a version of build_ios_framework_module_test that only runs on x64 machines and extend its timeout (flutter/flutter#176811)
    2025-10-10 [email protected] Roll Packages from 0b41de3 to e319c40 (1 revision) (flutter/flutter#176833)
    2025-10-10 [email protected] [tool/dap] Forward app.warning events from Flutter to DAP client (flutter/flutter#176827)
    2025-10-10 [email protected] Roll Dart SDK from 70c00d3ceb3a to d88d8bf2b53c (1 revision) (flutter/flutter#176830)
    2025-10-10 [email protected] Remove unnecessary nullable types in examples. (flutter/flutter#176713)
    2025-10-10 [email protected] Roll Fuchsia Linux SDK from xArtL4DH0FsdwSqG_... to JpiUsek1hU5r9QVKP... (flutter/flutter#176822)
    2025-10-10 [email protected] Cleanup OutlinedButton.icon documentation and implementation (flutter/flutter#176630)
    2025-10-10 [email protected] [HCPP] Properly remove hcpp views that are no longer visible (flutter/flutter#176742)
    2025-10-10 [email protected] Make sure that an InputChip doesn't crash in 0x0 environment (flutter/flutter#175930)
    2025-10-10 [email protected] Update Flutter templates' Dart style (flutter/flutter#175963)
    2025-10-10 [email protected] Make sure that a DropdownButtonFormField doesn't crash in 0x0 environ… (flutter/flutter#174958)
    2025-10-10 [email protected] Make sure that an InkWell doesn't crash in 0x0 environment (flutter/flutter#175871)
    2025-10-10 [email protected] Handle#6537 end drawer button (flutter/flutter#173026)
    2025-10-10 [email protected] Roll Dart SDK from a9b7bd4b0b32 to 70c00d3ceb3a (4 revisions) (flutter/flutter#176815)
    2025-10-10 [email protected] Change default Linux thread policy to merge platform and UI threads. (flutter/flutter#176759)
    2025-10-09 [email protected] [ Tool ] Roll package:dwds to 26.0.0 (flutter/flutter#176808)
    2025-10-09 [email protected] Update `CHANGELOG` to include 3.35.6 notes (flutter/flutter#176803)
    2025-10-09 [email protected] Announce text and button together when DropdownMenu is treated as a button (flutter/flutter#176428)
    2025-10-09 [email protected] [native_assets] create macOS CCompilerConfig via xcrun --find (flutter/flutter#175717)
    2025-10-09 [email protected] [Impeller] Fix broken links in README. (flutter/flutter#176770)
    2025-10-09 [email protected] Fix links to Custom Flutter Engine Embedders in README. (flutter/flutter#175807)
    ...
    engine-flutter-autoroll authored Oct 15, 2025
    Configuration menu
    Copy the full SHA
    aed47f1 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2025

  1. [dependabot]: Bump org.mockito.kotlin:mockito-kotlin from 6.0.0 to 6.…

    …1.0 in /packages/interactive_media_ads/android (#10221)
    
    Bumps [org.mockito.kotlin:mockito-kotlin](https://github.com/mockito/mockito-kotlin) from 6.0.0 to 6.1.0.
    <details>
    <summary>Release notes</summary>
    <p><em>Sourced from <a href="https://github.com/mockito/mockito-kotlin/releases">org.mockito.kotlin:mockito-kotlin's releases</a>.</em></p>
    <blockquote>
    <h2>v6.1.0</h2>
    <h4>6.1.0</h4>
    <ul>
    <li>2025-09-30 - <a href="https://github.com/mockito/mockito-kotlin/compare/v6.0.0...v6.1.0">1 commit(s)</a> by JuJup</li>
    <li>chore(deps): update mockito-core [(<a href="https://redirect.github.com/mockito/mockito-kotlin/issues/542">#542</a>)](<a href="https://redirect.github.com/mockito/mockito-kotlin/pull/542">mockito/mockito-kotlin#542</a>)</li>
    </ul>
    </blockquote>
    </details>
    <details>
    <summary>Commits</summary>
    <ul>
    <li><a href="https://github.com/mockito/mockito-kotlin/commit/29a7a996b29c83cfd4c08b5f2f85c88728640da2"><code>29a7a99</code></a> Update mockito-core to 5.20.0 (<a href="https://redirect.github.com/mockito/mockito-kotlin/issues/542">#542</a>)</li>
    <li>See full diff in <a href="https://github.com/mockito/mockito-kotlin/compare/v6.0.0...v6.1.0">compare view</a></li>
    </ul>
    </details>
    <br />
    
    [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.mockito.kotlin:mockito-kotlin&package-manager=gradle&previous-version=6.0.0&new-version=6.1.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
    
    Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
    
    ---
    
    <details>
    <summary>Dependabot commands and options</summary>
    <br />
    
    You can trigger Dependabot actions by commenting on this PR:
    - `@dependabot rebase` will rebase this PR
    - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
    - `@dependabot merge` will merge this PR after your CI passes on it
    - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
    - `@dependabot cancel merge` will cancel a previously requested merge and block automerging
    - `@dependabot reopen` will reopen this PR if it is closed
    - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
    - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
    - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
    - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
    - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    
    </details>
    dependabot[bot] authored Oct 16, 2025
    Configuration menu
    Copy the full SHA
    8588f1b View commit details
    Browse the repository at this point in the history
  2. [local_auth] Adopt structured errors and remove useErrorDialogs - pla…

    …tform implementations (#10147)
    
    Platform implementation portion of #9981
    
    - Adds the new `LocalAuthException` class for structured errors.
    - Deprecates `AuthenticationOptions.useErrorDialogs`
    
    Part of:
    - flutter/flutter#113687
    - flutter/flutter#175125
    
    ## Pre-Review Checklist
    
    [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
    stuartmorgan-g authored Oct 16, 2025
    Configuration menu
    Copy the full SHA
    835dccb View commit details
    Browse the repository at this point in the history
Loading