Repository navigation
Comparing changes
Open a pull request
base repository: flutter/packages
base: d862279f291f
head repository: flutter/packages
compare: 2a0f25419c52
- 14 commits
- 118 files changed
- 13 contributors
Commits on Aug 23, 2024
-
[go_router] Fixes issue so that the parseRouteInformationWithContext … (
#7337) �can handle non-http Uris. fixes flutter/flutter#148389
Configuration menu - View commit details
-
Copy full SHA for 25795a4 - Browse repository at this point
Copy the full SHA 25795a4View commit details -
[google_maps_flutter_android] Convert
PlatformTileOverlayto Pigeon (……#7467) Convert `PlatformTileOverlay` from using a JSON implementation to a structured typesafe one. Addresses flutter/flutter#152927, which concerns `PlatformTileOverlay` as well as `PlatformTile`. However, as it appears `PlatformTile` is already typesafe, this should resolve the issue. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] page, which explains my responsibilities. - [x] I read and followed the [relevant style guides] and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use `dart format`.) - [ ] I signed the [CLA]. - [x] The title of the PR starts with the name of the package surrounded by square brackets, e.g. `[shared_preferences]` - [x] I [linked to at least one issue that this PR fixes] in the description above. - [x] I updated `pubspec.yaml` with an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes]. - [x] I updated `CHANGELOG.md` to add a description of the change, [following repository CHANGELOG style], or this PR is [exempt from CHANGELOG changes]. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/packages/blob/main/CONTRIBUTING.md [Tree Hygiene]: https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md [relevant style guides]: https://github.com/flutter/packages/blob/main/CONTRIBUTING.md#style [CLA]: https://cla.developers.google.com/ [Discord]: https://github.com/flutter/flutter/blob/master/docs/contributing/Chat.md [linked to at least one issue that this PR fixes]: https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#overview [pub versioning philosophy]: https://dart.dev/tools/pub/versioning [exempt from version changes]: https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#version [following repository CHANGELOG style]: https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#changelog-style [exempt from CHANGELOG changes]: https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#changelog [test-exempt]: https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#tests
Configuration menu - View commit details
-
Copy full SHA for 1cf868f - Browse repository at this point
Copy the full SHA 1cf868fView commit details
Commits on Aug 24, 2024
-
[video_player] Relands #6456: Uses
SurfaceProducer, this time with ……`setCallback` for suspend/resume lifecycles. (#6989) _ð��« BLOCKED: I guess this can't land until the new API makes it into stable in a week or two?_ --- Effectively enough towards flutter/flutter#148417, but we still need to document it on flutter.dev. This is the last _technical_ PR I'll work on towards the plugin work (assuming we don't find additional bugs/issues). /cc @jonahwilliams @chinmaygarde @johnmccutchan.
Configuration menu - View commit details
-
Copy full SHA for 62b4cb0 - Browse repository at this point
Copy the full SHA 62b4cb0View commit details
Commits on Aug 26, 2024
-
Revert "[video_player] Relands #6456: Uses SurfaceProducer, this time…
… with setCallback for suspend/resume lifecycles" (#7497) Reverts #6989 Fixes flutter/flutter#154054 , flutter/flutter#154050
Configuration menu - View commit details
-
Copy full SHA for f61a98a - Browse repository at this point
Copy the full SHA f61a98aView commit details -
[url_launcher] Ignore new
unreachable_switch_defaultwarning. (#7487)The Dart analyzer will soon be changed so that if the `default` clause of a `switch` statement is determined to be unreachable by the exhaustiveness checker, a new warning of type `unreachable_switch_default` will be issued. This parallels the behavior of the existing `unreachable_switch_case` warning, which is issued whenever a `case` clause of a `switch` statement is determined to be unreachable. In the vast majority of cases, the most reasonable way to address the warning is to remove the unreachable `default` clause. However, in a few rare cases, it makes sense to keep the `default` clause, because it's intentionally future-proofing the code in case new possible values are added to the enum being switched on. Three of these rare cases crop up in flutter/packages. This change adds `ignore` comments to avoid a spurious warning.
Configuration menu - View commit details
-
Copy full SHA for 6c12c88 - Browse repository at this point
Copy the full SHA 6c12c88View commit details -
[video_player] Updates minimum supported SDK (#7498)
fixes flutter/flutter#154050 and flutter/flutter#154054 by setting the min sdk version
Configuration menu - View commit details
-
Copy full SHA for a0501f2 - Browse repository at this point
Copy the full SHA a0501f2View commit details -
[pigeon]: Bump org.jetbrains.kotlin:kotlin-gradle-plugin from 2.0.10 …
…to 2.0.20 in /packages/pigeon/platform_tests/test_plugin/android (#7500) Bumps [org.jetbrains.kotlin:kotlin-gradle-plugin](https://github.com/JetBrains/kotlin) from 2.0.10 to 2.0.20. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/JetBrains/kotlin/releases">org.jetbrains.kotlin:kotlin-gradle-plugin's releases</a>.</em></p> <blockquote> <h2>Kotlin 2.0.20</h2> <h2>Changelog</h2> <h3>Analysis. API</h3> <h4>New Features</h4> <ul> <li><a href="https://youtrack.jetbrains.com/issue/KT-68143"><code>KT-68143</code></a> Analysis API: support KtWhenConditionInRange call resolution</li> </ul> <h4>Performance Improvements</h4> <ul> <li><a href="https://youtrack.jetbrains.com/issue/KT-67195"><code>KT-67195</code></a> K2: do not call redundant resolve on body resolution phase for classes</li> </ul> <h4>Fixes</h4> <ul> <li><a href="https://youtrack.jetbrains.com/issue/KT-67360"><code>KT-67360</code></a> Analysis API: KtDestructuringDeclarationSymbol#entries shouldn't be KtLocalVariableSymbol</li> <li><a href="https://youtrack.jetbrains.com/issue/KT-67748"><code>KT-67748</code></a> K2: AllCandidatesResolver modifies the original FirDelegatedConstructorCall</li> <li><a href="https://youtrack.jetbrains.com/issue/KT-68198"><code>KT-68198</code></a> Analysis API: Support application service registration in plugin XMLs</li> <li><a href="https://youtrack.jetbrains.com/issue/KT-62936"><code>KT-62936</code></a> Analysis API: NativeForwardDeclarationsSymbolProvider is not supported for Kotlin/Native</li> <li><a href="https://youtrack.jetbrains.com/issue/KT-68689"><code>KT-68689</code></a> LL API: support analysis from builtins module</li> <li><a href="https://youtrack.jetbrains.com/issue/KT-69630"><code>KT-69630</code></a> KAPT User project builds with KAPT4 enabled fail with Metaspace overflow</li> <li><a href="https://youtrack.jetbrains.com/issue/KT-65417"><code>KT-65417</code></a> K2 IDE: KTOR false positive expect-actual matching error on enum class because of implicit clone() in non-JVM source sets</li> <li><a href="https://youtrack.jetbrains.com/issue/KT-68882"><code>KT-68882</code></a> Analysis API: Refactor <code>KaSymbol</code>s</li> <li><a href="https://youtrack.jetbrains.com/issue/KT-65413"><code>KT-65413</code></a> K2 IDE: KTOR unresolved serializer() call for <code>@serializable</code> class in common code</li> <li><a href="https://youtrack.jetbrains.com/issue/KT-67996"><code>KT-67996</code></a> Analysis API: rename Kt prefix to Ka</li> <li><a href="https://youtrack.jetbrains.com/issue/KT-67775"><code>KT-67775</code></a> Analysis API: expose only interfaces/abstract classes for the user surface</li> <li><a href="https://youtrack.jetbrains.com/issue/KT-68009"><code>KT-68009</code></a> K2: lowering transformers of Compose compiler plugin access AbstractFir2IrLazyFunction modality, which results in null point exception</li> <li><a href="https://youtrack.jetbrains.com/issue/KT-68918"><code>KT-68918</code></a> collectCallCandidates works incorrectly for parenthesis invoke</li> <li><a href="https://youtrack.jetbrains.com/issue/KT-68462"><code>KT-68462</code></a> Analysis API: Integrate <code>project-structure</code> module into <code>analysis-api</code> and <code>analysis-api-platform-interface</code></li> <li><a href="https://youtrack.jetbrains.com/issue/KT-69131"><code>KT-69131</code></a> AA: "provideDelegate" operator is not resolved from the delegation reference in FIR implementation</li> <li><a href="https://youtrack.jetbrains.com/issue/KT-69055"><code>KT-69055</code></a> Analysis API: Stabilize <code>KaScope</code>s</li> <li><a href="https://youtrack.jetbrains.com/issue/KT-66216"><code>KT-66216</code></a> K2 IDE. "FirDeclaration was not found for class org.jetbrains.kotlin.psi.KtProperty, fir is null" on incorrect string template</li> <li><a href="https://youtrack.jetbrains.com/issue/KT-68959"><code>KT-68959</code></a> Introduce KaSeverity</li> <li><a href="https://youtrack.jetbrains.com/issue/KT-53669"><code>KT-53669</code></a> Analysis API: redesign KtSymbolOrigin to distinguish kotlin/java source/library declarations</li> <li><a href="https://youtrack.jetbrains.com/issue/KT-68846"><code>KT-68846</code></a> Mark KaFirReference and all implementations with internal modifier</li> <li><a href="https://youtrack.jetbrains.com/issue/KT-68845"><code>KT-68845</code></a> Move KaSymbolBasedReference to resolution package</li> <li><a href="https://youtrack.jetbrains.com/issue/KT-68844"><code>KT-68844</code></a> Move KaTypeProjection to types package</li> <li><a href="https://youtrack.jetbrains.com/issue/KT-65849"><code>KT-65849</code></a> K2: Rename 'high-level-api' family of JARs to 'analysis-api'</li> <li><a href="https://youtrack.jetbrains.com/issue/KT-62540"><code>KT-62540</code></a> Remove uses of TypeInfo.fromString and TypeInfo.createTypeText from Kotlin plugin</li> <li><a href="https://youtrack.jetbrains.com/issue/KT-62889"><code>KT-62889</code></a> K2 IDE. FP <code>MISSING_DEPENDENCY_CLASS</code> on not available type alias with available underlying type</li> <li><a href="https://youtrack.jetbrains.com/issue/KT-68155"><code>KT-68155</code></a> Analysis API: Add PSI validity check to <code>analyze</code></li> <li><a href="https://youtrack.jetbrains.com/issue/KT-62343"><code>KT-62343</code></a> Analysis API: fix binary incopatibility problems cause by <code>KtAnalysisSessionProvider.analyze</code> being inline</li> <li><a href="https://youtrack.jetbrains.com/issue/KT-68498"><code>KT-68498</code></a> To get reference symbol the one should be KtSymbolBasedReference</li> <li><a href="https://youtrack.jetbrains.com/issue/KT-68393"><code>KT-68393</code></a> Analysis API: Rename <code>KaClassLikeSymbol. classIdIfNonLocal</code> to <code>classId</code></li> <li><a href="https://youtrack.jetbrains.com/issue/KT-62924"><code>KT-62924</code></a> Analysis API: rename KtCallableSymbol.callableIdIfNonLocal -> callableId</li> <li><a href="https://youtrack.jetbrains.com/issue/KT-66712"><code>KT-66712</code></a> K2 IDE. SOE on settings string template for string variable with the same name</li> <li><a href="https://youtrack.jetbrains.com/issue/KT-65892"><code>KT-65892</code></a> K2: "We should be able to find a symbol" for findNonLocalFunction</li> <li><a href="https://youtrack.jetbrains.com/issue/KT-68273"><code>KT-68273</code></a> AA: support <code>KtFirKDocReference#isReferenceToImportAlias</code></li> <li><a href="https://youtrack.jetbrains.com/issue/KT-68272"><code>KT-68272</code></a> AA: KtFirReference.isReferenceToImportAlias doesn't work for references on constructor</li> <li><a href="https://youtrack.jetbrains.com/issue/KT-66996"><code>KT-66996</code></a> Analysis API: Expose the abbreviated type of an expanded <code>KtType</code></li> <li><a href="https://youtrack.jetbrains.com/issue/KT-66646"><code>KT-66646</code></a> K2: Expected FirResolvedTypeRef with ConeKotlinType but was FirUserTypeRefImpl from FirJsHelpersKt.isExportedObject</li> </ul> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/JetBrains/kotlin/blob/v2.0.20/ChangeLog.md">org.jetbrains.kotlin:kotlin-gradle-plugin's changelog</a>.</em></p> <blockquote> <h2>2.0.20</h2> <h3>Analysis. API</h3> <h4>New Features</h4> <ul> <li><a href="https://youtrack.jetbrains.com/issue/KT-68143"><code>KT-68143</code></a> Analysis API: support KtWhenConditionInRange call resolution</li> </ul> <h4>Performance Improvements</h4> <ul> <li><a href="https://youtrack.jetbrains.com/issue/KT-67195"><code>KT-67195</code></a> K2: do not call redundant resolve on body resolution phase for classes</li> </ul> <h4>Fixes</h4> <ul> <li><a href="https://youtrack.jetbrains.com/issue/KT-67360"><code>KT-67360</code></a> Analysis API: KtDestructuringDeclarationSymbol#entries shouldn't be KtLocalVariableSymbol</li> <li><a href="https://youtrack.jetbrains.com/issue/KT-67748"><code>KT-67748</code></a> K2: AllCandidatesResolver modifies the original FirDelegatedConstructorCall</li> <li><a href="https://youtrack.jetbrains.com/issue/KT-68198"><code>KT-68198</code></a> Analysis API: Support application service registration in plugin XMLs</li> <li><a href="https://youtrack.jetbrains.com/issue/KT-62936"><code>KT-62936</code></a> Analysis API: NativeForwardDeclarationsSymbolProvider is not supported for Kotlin/Native</li> <li><a href="https://youtrack.jetbrains.com/issue/KT-68689"><code>KT-68689</code></a> LL API: support analysis from builtins module</li> <li><a href="https://youtrack.jetbrains.com/issue/KT-69630"><code>KT-69630</code></a> KAPT User project builds with KAPT4 enabled fail with Metaspace overflow</li> <li><a href="https://youtrack.jetbrains.com/issue/KT-65417"><code>KT-65417</code></a> K2 IDE: KTOR false positive expect-actual matching error on enum class because of implicit clone() in non-JVM source sets</li> <li><a href="https://youtrack.jetbrains.com/issue/KT-68882"><code>KT-68882</code></a> Analysis API: Refactor <code>KaSymbol</code>s</li> <li><a href="https://youtrack.jetbrains.com/issue/KT-65413"><code>KT-65413</code></a> K2 IDE: KTOR unresolved serializer() call for <code>@serializable</code> class in common code</li> <li><a href="https://youtrack.jetbrains.com/issue/KT-67996"><code>KT-67996</code></a> Analysis API: rename Kt prefix to Ka</li> <li><a href="https://youtrack.jetbrains.com/issue/KT-67775"><code>KT-67775</code></a> Analysis API: expose only interfaces/abstract classes for the user surface</li> <li><a href="https://youtrack.jetbrains.com/issue/KT-68009"><code>KT-68009</code></a> K2: lowering transformers of Compose compiler plugin access AbstractFir2IrLazyFunction modality, which results in null point exception</li> <li><a href="https://youtrack.jetbrains.com/issue/KT-68918"><code>KT-68918</code></a> collectCallCandidates works incorrectly for parenthesis invoke</li> <li><a href="https://youtrack.jetbrains.com/issue/KT-68462"><code>KT-68462</code></a> Analysis API: Integrate <code>project-structure</code> module into <code>analysis-api</code> and <code>analysis-api-platform-interface</code></li> <li><a href="https://youtrack.jetbrains.com/issue/KT-69131"><code>KT-69131</code></a> AA: "provideDelegate" operator is not resolved from the delegation reference in FIR implementation</li> <li><a href="https://youtrack.jetbrains.com/issue/KT-69055"><code>KT-69055</code></a> Analysis API: Stabilize <code>KaScope</code>s</li> <li><a href="https://youtrack.jetbrains.com/issue/KT-66216"><code>KT-66216</code></a> K2 IDE. "FirDeclaration was not found for class org.jetbrains.kotlin.psi.KtProperty, fir is null" on incorrect string template</li> <li><a href="https://youtrack.jetbrains.com/issue/KT-68959"><code>KT-68959</code></a> Introduce KaSeverity</li> <li><a href="https://youtrack.jetbrains.com/issue/KT-53669"><code>KT-53669</code></a> Analysis API: redesign KtSymbolOrigin to distinguish kotlin/java source/library declarations</li> <li><a href="https://youtrack.jetbrains.com/issue/KT-68846"><code>KT-68846</code></a> Mark KaFirReference and all implementations with internal modifier</li> <li><a href="https://youtrack.jetbrains.com/issue/KT-68845"><code>KT-68845</code></a> Move KaSymbolBasedReference to resolution package</li> <li><a href="https://youtrack.jetbrains.com/issue/KT-68844"><code>KT-68844</code></a> Move KaTypeProjection to types package</li> <li><a href="https://youtrack.jetbrains.com/issue/KT-65849"><code>KT-65849</code></a> K2: Rename 'high-level-api' family of JARs to 'analysis-api'</li> <li><a href="https://youtrack.jetbrains.com/issue/KT-62540"><code>KT-62540</code></a> Remove uses of TypeInfo.fromString and TypeInfo.createTypeText from Kotlin plugin</li> <li><a href="https://youtrack.jetbrains.com/issue/KT-62889"><code>KT-62889</code></a> K2 IDE. FP <code>MISSING_DEPENDENCY_CLASS</code> on not available type alias with available underlying type</li> <li><a href="https://youtrack.jetbrains.com/issue/KT-68155"><code>KT-68155</code></a> Analysis API: Add PSI validity check to <code>analyze</code></li> <li><a href="https://youtrack.jetbrains.com/issue/KT-62343"><code>KT-62343</code></a> Analysis API: fix binary incopatibility problems cause by <code>KtAnalysisSessionProvider.analyze</code> being inline</li> <li><a href="https://youtrack.jetbrains.com/issue/KT-68498"><code>KT-68498</code></a> To get reference symbol the one should be KtSymbolBasedReference</li> <li><a href="https://youtrack.jetbrains.com/issue/KT-68393"><code>KT-68393</code></a> Analysis API: Rename <code>KaClassLikeSymbol. classIdIfNonLocal</code> to <code>classId</code></li> <li><a href="https://youtrack.jetbrains.com/issue/KT-62924"><code>KT-62924</code></a> Analysis API: rename KtCallableSymbol.callableIdIfNonLocal -> callableId</li> <li><a href="https://youtrack.jetbrains.com/issue/KT-66712"><code>KT-66712</code></a> K2 IDE. SOE on settings string template for string variable with the same name</li> <li><a href="https://youtrack.jetbrains.com/issue/KT-65892"><code>KT-65892</code></a> K2: "We should be able to find a symbol" for findNonLocalFunction</li> <li><a href="https://youtrack.jetbrains.com/issue/KT-68273"><code>KT-68273</code></a> AA: support <code>KtFirKDocReference#isReferenceToImportAlias</code></li> <li><a href="https://youtrack.jetbrains.com/issue/KT-68272"><code>KT-68272</code></a> AA: KtFirReference.isReferenceToImportAlias doesn't work for references on constructor</li> <li><a href="https://youtrack.jetbrains.com/issue/KT-66996"><code>KT-66996</code></a> Analysis API: Expose the abbreviated type of an expanded <code>KtType</code></li> <li><a href="https://youtrack.jetbrains.com/issue/KT-66646"><code>KT-66646</code></a> K2: Expected FirResolvedTypeRef with ConeKotlinType but was FirUserTypeRefImpl from FirJsHelpersKt.isExportedObject</li> </ul> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/JetBrains/kotlin/commit/6af99c83470813023dace7d3bd850c6fef8e50c0"><code>6af99c8</code></a> Add changelog for 2.0.20</li> <li><a href="https://github.com/JetBrains/kotlin/commit/68f075d25ed33bf1d3a5820a961f1e9ca9d8d433"><code>68f075d</code></a> Add ChangeLog for 2.0.20-RC2</li> <li><a href="https://github.com/JetBrains/kotlin/commit/2b7c4f71510373e30c192b6fbcf56758a329d041"><code>2b7c4f7</code></a> [K/Wasm] Don't add mappings into source-maps for unavailable sources</li> <li><a href="https://github.com/JetBrains/kotlin/commit/e35e9aefa0ea982affe04d72a277aadab61c4dd9"><code>e35e9ae</code></a> Update codeowners</li> <li><a href="https://github.com/JetBrains/kotlin/commit/c580c67ac21c5d8580b7d03284758cfce136fd98"><code>c580c67</code></a> [K/N] Remember StableRefs, released during RC colleciton (KT-70159)</li> <li><a href="https://github.com/JetBrains/kotlin/commit/565a35c92798ee8fcf0e0678ddce307d4c2ee4cf"><code>565a35c</code></a> [FIR2IR] Unset <code>isLateinit</code> flag for properties implemented by delegation</li> <li><a href="https://github.com/JetBrains/kotlin/commit/5607bd36b1f365dce719c21d3011336dc18edf12"><code>5607bd3</code></a> [Test] Reproduce KT-70417</li> <li><a href="https://github.com/JetBrains/kotlin/commit/ce5d599f21737d6602a04a11a02998dcab7f9c2c"><code>ce5d599</code></a> [K/JS] Fix coroutines on ES2015 generators when there is not a GeneratorCorou...</li> <li><a href="https://github.com/JetBrains/kotlin/commit/ca9fb23cffab4519e5b26a2bfd6b3b1598b8a55f"><code>ca9fb23</code></a> Disallow open <a href="https://github.com/Composable"><code>@â��Composable</code></a> functions with default params</li> <li><a href="https://github.com/JetBrains/kotlin/commit/9a4c77e23d27fa944fc263660976352072462b81"><code>9a4c77e</code></a> Update codeowners</li> <li>Additional commits viewable in <a href="https://github.com/JetBrains/kotlin/compare/v2.0.10...v2.0.20">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>
Configuration menu - View commit details
-
Copy full SHA for b9715b7 - Browse repository at this point
Copy the full SHA b9715b7View commit details
Commits on Aug 27, 2024
-
Cupertino icons golden tests (#7421)
This is for flutter/flutter#148075, we want to make sure the glyphs don't look different when the font generation script is migrated from python. Also it will be nice to be able to inspect glyph changes whenever the ttf file gets updated. The `flutter test` command takes 6s to complete on my computer. Unfortunately this test: - is sensitive to how flutter renders text on Linux, and how the `Icon` widget positions the glyph. - will require contributors to have access to a Linux box in order to generate new goldens. The tests are disabled on the web since it needs the `dart:io` import. The `icons_list.dart` file is automatically generated. Not sure if there's a way to incorporate the code gen step on CI?
Configuration menu - View commit details
-
Copy full SHA for ef81058 - Browse repository at this point
Copy the full SHA ef81058View commit details -
[in_app_purchase_storekit] Allows 'localizedDescription' to be nullab…
…le to handle occasional nulls in Storekit objects (#7515) Fixes flutter/flutter#154047 The Pigeon representation of the attribute `localizedDescription` of the Storekit object [SKProduct](https://developer.apple.com/documentation/storekit/skproduct) assumes that it is nonnullable, as per the documentation. It is in fact nullable sometimes, so the pigeon representation is relaxed to allow for that.
Configuration menu - View commit details
-
Copy full SHA for 1d1fc4f - Browse repository at this point
Copy the full SHA 1d1fc4fView commit details -
[google_sign_in_ios] Fix "callee requires a non-null parameter" analy…
…zer warning (#7513) The normal Cocoa pattern is to check a result, and only if it's nil then do something with the error. https://developer.apple.com/library/archive/documentation/Cocoa/Conceptual/ErrorHandlingCocoa/CreateCustomizeNSError/CreateCustomizeNSError.html > Important: Success or failure is indicated by the return value of the method. Although Cocoa methods that indirectly return error objects in the Cocoa error domain are guaranteed to return such objects if the method indicates failure by directly returning nil or NO, you should always check that the return value is nil or NO before attempting to do anything with the NSError object. Use this pattern with the result and error from the sign in completion block. This means `-didSignInForUser` is only called for non-nil users (the possibility of a nullable parameter was kicking off the analyzer warning).  Fixes flutter/flutter#153587
Configuration menu - View commit details
-
Copy full SHA for ce17b4b - Browse repository at this point
Copy the full SHA ce17b4bView commit details -
Configuration menu - View commit details
-
Copy full SHA for bcb09db - Browse repository at this point
Copy the full SHA bcb09dbView commit details -
Remove matan from codeowners (#7511)
Now that the patches have landed there isn't a lot of value in me getting notified about every change to each package. I'm of course still happy to help, but I'll have to be reached in a different way than the `CODEOWNERS` mechanism :)
Configuration menu - View commit details
-
Copy full SHA for cc7b5fc - Browse repository at this point
Copy the full SHA cc7b5fcView commit details
Commits on Aug 28, 2024
-
[shared_preferences] Fix typo in changelog (#7523)
This PR fixes a typo in the changelog of shared_preferences, relating to what Dart / Flutter version are supported from version 2.3.2 onwards Fixes flutter/flutter#154177 I'm not sure if this requires a version change. Does it fall under "Updating the minimum Dart or Flutter SDK for all packages when we adjust our test matrix." ? Although, developers probably want to see this corrected on Pub, so that would require a version change?
Configuration menu - View commit details
-
Copy full SHA for afc24ac - Browse repository at this point
Copy the full SHA afc24acView commit details -
[interactive_media_ads] Adds internal wrapper for remaining methods o…
…f the Android native `AdsManager` (#7437)
Configuration menu - View commit details
-
Copy full SHA for 2a0f254 - Browse repository at this point
Copy the full SHA 2a0f254View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff d862279f291f...2a0f25419c52