Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/packages
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: ed235d11b7fd
Choose a base ref
...
head repository: flutter/packages
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: d91412017a01
Choose a head ref
  • 4 commits
  • 34 files changed
  • 2 contributors

Commits on Jul 29, 2025

  1. [video_player] Move more Java logic to Dart (#9672)

    Moves some logic from native code to Dart:
    - User-Agent header -> ExoPlayer user agent extraction logic (with TODOs for future improvements, based on implementation issues/questions I noticed while converting it).
    - Asset -> URL lookup.
    - Conversion of buffer position to the buffer range list required for the Dart event stream.
    
    Also converts video format hint from strings to enums, which was missed in earlier Pigeon conversions. Using strings was the pre-Pigeon way of handling this kind of thing.
    
    Part of flutter/flutter#172763
    
    ## Pre-Review Checklist
    
    **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.
    
    [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
    stuartmorgan-g authored Jul 29, 2025
    Configuration menu
    Copy the full SHA
    733d1cb View commit details
    Browse the repository at this point in the history
  2. Update CODEOWNERS (#9692)

    Set myself as the CODEOWNER of Linux and Windows plugins, as I currently have the most experience with them.
    
    Other minor changes to owners to reflect current owners.
    stuartmorgan-g authored Jul 29, 2025
    Configuration menu
    Copy the full SHA
    792b70b View commit details
    Browse the repository at this point in the history
  3. [video_player] Move more Obj-C logic to Dart (#9685)

    Moves some logic from native code to Dart:
    - Asset -> URL lookup.
    - Conversion from native buffer range format (start+duration) to Dart range format (start+end).
    
    Also does some minor native cleanup:
    - Removes unnecessary state from `FVPVideoPlayerPlugin`; several registrar-vended objects were being stored, and later changes required storing the registrar itself, so now we can just get those from the registrar on demand.
    - Removes nil player handling; the player can never return nil now.
    - Removes `formatHint` from the Pigeon interface; it was only ever used on Android, so doesn't need to be sent across the language boundary.
    
    Part of flutter/flutter#172763
    
    ## Pre-Review Checklist
    
    **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.
    
    [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
    stuartmorgan-g authored Jul 29, 2025
    Configuration menu
    Copy the full SHA
    5d2a10f View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2025

  1. Roll Flutter from 46b097a to c3279ca (18 revisions) (#9699)

    flutter/flutter@46b097a...c3279ca
    
    2025-07-30 [email protected] Roll Skia from 00765f238077 to da5a6704f8a3 (1 revision) (flutter/flutter#172966)
    2025-07-30 [email protected] Roll Skia from 62476cd444d2 to 00765f238077 (3 revisions) (flutter/flutter#172955)
    2025-07-30 [email protected] Roll Skia from 34693354289f to 62476cd444d2 (1 revision) (flutter/flutter#172950)
    2025-07-30 [email protected] Roll Skia from f72bd01a49b1 to 34693354289f (1 revision) (flutter/flutter#172946)
    2025-07-30 [email protected] [a11y] add RangeSlider to a11y test app as additional use-case (flutter/flutter#172922)
    2025-07-30 [email protected] Roll Skia from a42898e5d622 to f72bd01a49b1 (21 revisions) (flutter/flutter#172944)
    2025-07-29 [email protected] Fix SegmentedButton border doesn't reflect states (flutter/flutter#172754)
    2025-07-29 [email protected] Fix documentation for FlutterEngineRunTask (flutter/flutter#172889)
    2025-07-29 [email protected] Roll Fuchsia Linux SDK from tK_PAaLeo0pUxi8hv... to bQVQlLssTxxLjoDU0... (flutter/flutter#172925)
    2025-07-29 [email protected] fix(scrollbar): Update padding type to EdgeInsetsGeometry (flutter/flutter#172056)
    2025-07-29 [email protected] Refactor Android platform view code in advance of enabling HCPP on existing PV widgets (behind a flag) (flutter/flutter#170553)
    2025-07-29 [email protected] Roll Packages from 6b2e34e to ed235d1 (4 revisions) (flutter/flutter#172905)
    2025-07-29 [email protected] Add package PR triage note (flutter/flutter#172898)
    2025-07-29 [email protected] Roll Skia from 409e1c7ba09b to a42898e5d622 (29 revisions) (flutter/flutter#172906)
    2025-07-29 [email protected] Made `android_gradle_print_build_variants_test.dart` more robust (flutter/flutter#172910)
    2025-07-29 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reland licenses cpp switch (#172671)" (flutter/flutter#172912)
    2025-07-29 [email protected] Fix Gemini Code Assist for GitHub config yaml (flutter/flutter#172887)
    2025-07-29 [email protected] Marks Linux_android_emu_unstable android_defines_test to be unflaky (flutter/flutter#171856)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-packages
    Please CC [email protected],[email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Jul 30, 2025
    Configuration menu
    Copy the full SHA
    d914120 View commit details
    Browse the repository at this point in the history
Loading