Repository navigation
Sync release-material_ui-1.3.0 to main - #12873
Merged
Merged
Conversation
This PR was created automatically to batch release the `material_ui`.
fluttergithubbot
added
the
override: batch-material_ui
github-actions
Bot
added
p: material_ui
triage-design
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the material_ui package version to 1.3.0 and consolidates individual changelog entries into the main CHANGELOG.md file. The reviewer provided a suggestion to add a trailing period to one of the changelog entries to ensure consistency with the rest of the documentation.
|
|
||
| - Adds `@awaitNotRequired` annotations to asynchronous functions that do not need to be awaited. | ||
| - Adds an option for `MaterialPageRoute` and `MaterialPage` to opt out of introducing a semantics route scope. | ||
| - Fixes SliverGeometry maxPaintExtent assertion in CarouselView.weighted |
Contributor
There was a problem hiding this comment.
The changelog entry is missing a trailing period, which is inconsistent with the other entries in this release section. Please add a period at the end of the sentence to maintain consistency.
Suggested change
| - Fixes SliverGeometry maxPaintExtent assertion in CarouselView.weighted | |
| - Fixes SliverGeometry maxPaintExtent assertion in CarouselView.weighted. |
|
material_ui-1.3.0 declares flutter: ">=3.44.0" as a constraint, but uses @awaitNotRequired which does not exist in Flutter 3.44.9 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This automated PR syncs the changes from the release branch release-material_ui-1.3.0 back to the main branch.