Repository navigation
Sync release-cupertino_ui-1.1.0 to main - #12874
Merged
Merged
Conversation
This PR was created automatically to batch release the `cupertino_ui`.
fluttergithubbot
added
the
override: batch-cupertino_ui
github-actions
Bot
added
p: cupertino_ui
triage-design
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the cupertino_ui package version to 1.1.0, consolidates individual changelog snippets into the main CHANGELOG.md file, and removes the snippet files. The review feedback suggests standardizing the verb tenses in the new changelog entries to the imperative present tense for consistency.
Comment on lines
+3
to
+9
| - Add `hasPlatformViews` to Cupertino sheet transitions to keep platform views synchronized with the underlying route. | ||
| - Allows `CupertinoTabBar` to contain a single item. | ||
| - Fixed some leaks of TextEditingControllers in the cupertino_ui magnifier examples. | ||
| - Fixed an issue where the `CupertinoIcons` font was not included in the cupertino_ui examples. | ||
| - Adds an option for `CupertinoPageRoute` and `CupertinoPage` to opt out of introducing a semantics route scope. | ||
| - Fixes lower routes being revealed through the top gap when multiple `CupertinoSheetRoute`s are stacked. | ||
| - Adds awaitNotRequired annotation to showCupertinoModalPopup and showCupertinoDialog. |
Contributor
There was a problem hiding this comment.
The changelog entries use inconsistent verb tenses (e.g., "Add", "Allows", "Fixed", "Adds", "Fixes"). To maintain a clean and professional changelog, it is best practice to use a consistent grammatical style, preferably the imperative present tense (e.g., "Add", "Allow", "Fix"), which also aligns with the existing entry under 1.0.1.
Here is the suggested revision:
- Add `hasPlatformViews` to Cupertino sheet transitions to keep platform views synchronized with the underlying route.
- Allow `CupertinoTabBar` to contain a single item.
- Fix some leaks of TextEditingControllers in the cupertino_ui magnifier examples.
- Fix an issue where the `CupertinoIcons` font was not included in the cupertino_ui examples.
- Add an option for `CupertinoPageRoute` and `CupertinoPage` to opt out of introducing a semantics route scope.
- Fix lower routes being revealed through the top gap when multiple `CupertinoSheetRoute`s are stacked.
- Add awaitNotRequired annotation to showCupertinoModalPopup and showCupertinoDialog.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This automated PR syncs the changes from the release branch release-cupertino_ui-1.1.0 back to the main branch.