Skip to content

[go_router] Batch release - #13042

Merged
auto-submit[bot] merged 1 commit into
release-go_router-18.0.2from
go_router-36396670245-1
Sep 28, 2026
Merged

auto-submit[bot] merged 1 commit into
release-go_router-18.0.2from
go_router-36396670245-1

Conversation

@fluttergithubbot

Copy link
Copy Markdown
Contributor

This PR was created automatically to batch release the go_router.

@fluttergithubbot fluttergithubbot added the override: batch-go_router label used for post release sync label Sep 28, 2026
@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Sep 28, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the go_router package to version 18.0.2, adding changelog entries for fixes related to ShellRoute/StatefulShellRoute semantics and nested pushed routes, while removing temporary metadata files. A review comment suggests adding a missing bullet point to the second changelog entry to maintain consistent list formatting.

## 18.0.2

- Fixes `ShellRoute`/`StatefulShellRoute` shell chrome (e.g. a side rail or app bar painted before the routed child) being dropped from the semantics tree by the active route's `ModalBarrier`.
Fixes pushed routes nested within a shell being lost when a dynamic routing configuration changes.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The second changelog entry is missing a bullet point, which makes the list formatting inconsistent. Please add a bullet point to match the first entry.

Suggested change
Fixes pushed routes nested within a shell being lost when a dynamic routing configuration changes.
- Fixes pushed routes nested within a shell being lost when a dynamic routing configuration changes.

@Piinks Piinks left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Piinks Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 28, 2026
@auto-submit
auto-submit Bot merged commit c30ba9e into release-go_router-18.0.2 Sep 28, 2026
5 checks passed
@auto-submit
auto-submit Bot deleted the go_router-36396670245-1 branch September 28, 2026 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App CICD Run CI/CD override: batch-go_router label used for post release sync p: go_router

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants