Skip to content

[google_maps_flutter_platform_interface] Adds point of interest event handler interface (#60695) - #4063

Closed
bndos wants to merge 6 commits into
flutter:mainfrom
bndos:feature/point-of-interest-interface
Closed

bndos wants to merge 6 commits into
flutter:mainfrom
bndos:feature/point-of-interest-interface

Conversation

@bndos

@bndos bndos commented May 22, 2023

Copy link
Copy Markdown

Issue #60695 mentions the lack of on point of interest event listener. This package (google_maps_flutter_platform_interface) needs to be released first so that the other google maps platform specific packages gain the ability to implement onPoiClick.

Issue link: flutter/flutter#60695

… handler interface

This commit addresses issue #60695, which mentions the lack of an on point of interest event listener. The google_maps_flutter_platform_interface package is being released first to enable other Google Maps platform-specific packages to implement the onPoiClick feature.

See: flutter/flutter#60695
@bndos
bndos requested a review from stuartmorgan-g as a code owner May 22, 2023 18:55
@flutter-dashboard

Copy link
Copy Markdown

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@stuartmorgan-g

Copy link
Copy Markdown
Collaborator

Per my comment in the other PR, the change isn't at the stage where we would review the interface PR yet, so marking as a draft.

@stuartmorgan-g

Copy link
Copy Markdown
Collaborator

Update from triage: this is still waiting on the main PR, which is in review.

@stuartmorgan-g

Copy link
Copy Markdown
Collaborator

Closing for now since the main PR is closed, but if you decide to come back to that one and it's fully reviewed and approved we can reopen this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants