Repository navigation
LinkedText - #5862
Closed
justinmc wants to merge 30 commits into
Closed
LinkedText#5862justinmc wants to merge 30 commits into
justinmc wants to merge 30 commits into
Conversation
Member
|
I spoke to @justinmc and he said this is back on his radar. |
Collaborator
|
From triage: is this still being worked on? |
Contributor
Author
|
Yes I plan to finish this up. |
Member
|
(triage) Spoke to @justinmc last week and he indicated that this one is still on his radar. |
Contributor
|
(PR triage): This was included in our team planning for this quarter as a P2. |
Contributor
Author
|
I'm planning to get back to this this quarter. |
This reverts commit 501c9cc. Didn't work! Now the analyzer says it's looking for the missing analysis_options file.
Whoops, I had removed the root analyzer_options file :). Let's try just the one in linked_text.
TODO: Make sure they take advantage of being able to launch a URL themselves (not needing to use url_launcher in the example). Maybe TextLinker or that file need to do so too?
Contributor
|
👋 Greetings from stale PR triage, no nudge though. I know this is on your radar. 😜 |
Contributor
|
Greetings from stale PR triage! 👋 |
Contributor
Author
|
Closing as I'm not actively working on this, but I do plan to come back and try to land this when I have time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A new package that provides the ability to automatically add working links into text.
This was originally part of the framework (flutter/flutter#125927), but is being moved to a package. The reason is a close dependency on the
url_launcherpackage for most functionality, which the Flutter framework does not depend on. Specifically, building a fully functional link on the web platform requires url_launcher'sLinkwidget, and that's something I want users to have out of the box.