Repository navigation
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
@googlebot I signed it! |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
|
@yinsee this may need a test in |
|
@ened added test (and found a bug!) |
|
@yinsee could you try restarting the failed checks (click on Details -> retry, I think) so that we have it green? |
| /// Controls whether WebView have bounce effect in iOS | ||
| /// | ||
| /// By default `scrollViewBounces` is true. | ||
| final bool scrollViewBounces; |
There was a problem hiding this comment.
I'm wondering whether it makes sense to phrase this as a platform-agnostic API?
e.g I'd imagine that on Android an equivalent knob will control whether the overflow glow is showing or not (not sure whether the Android webview currently allows such control).
In that case maybe it makes sense to name this something like allowOverScroll ?
| // no-op debugging is always enabled on iOS. | ||
| } else if ([key isEqualToString:@"scrollViewBounces"]) { | ||
| NSNumber* scrollViewBounces = settings[key]; | ||
| _webView.scrollView.bounces = [scrollViewBounces boolValue]; |
There was a problem hiding this comment.
I'm unfamiliar with this knob, do you know how does it play with the css overscroll-behavior parameter?
| /// | ||
| /// See also: [WebView.debuggingEnabled]. | ||
| final bool debuggingEnabled; | ||
| final bool scrollViewBounces; |
…1977) * [cloud_firestore] Endorse cloud_firestore_web. This change makes `cloud_firestore_web` the official implementation of `cloud_firestore` for the Web target. It also adds web support to the `example` app. Co-authored-by: Amr Yousef <[email protected]>
stuartmorgan-g
added
the
p: webview_flutter
|
Thank you for your contribution. I'm going to close this PR for now since there are outstanding comments, just to get this off our PR review queue. Please don't hesitate to submit a new PR if you have the time to address the review comments. Thanks! |
6 participants
Description
add scrollViewBounces settings to disable bounce effect on iOS.
flutter/flutter#57090
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?