Repository navigation
Update App Clip for Xcode 15 and iOS 16+ - #2162
Conversation
| <string>1.0</string> | ||
| <key>MinimumOSVersion</key> | ||
| <string>9.0</string> | ||
| <string>12.0</string> |
There was a problem hiding this comment.
Automigration from the flutter tool.
| @@ -1,5 +1,5 @@ | |||
| # Uncomment this line to define a global platform for your project | |||
| # platform :ios, '9.0' | |||
| # platform :ios, '12.0' | |||
There was a problem hiding this comment.
Automigration from the flutter tool.
| classes = { | ||
| }; | ||
| objectVersion = 51; | ||
| objectVersion = 54; |
There was a problem hiding this comment.
Automigration from the flutter tool.
| 0A48A2562508B57F0036A529 /* Frameworks */, | ||
| 0A48A2572508B57F0036A529 /* Resources */, | ||
| 0A48A2792508C8F70036A529 /* Embed Flutter */, | ||
| 1999EAF6C873AB834CA4DC07 /* [CP] Embed Pods Frameworks */, |
| 9705A1C41CF9048500538489 /* Embed Frameworks */, | ||
| 3B06AD1E1E4923F5004D2608 /* Thin Binary */, | ||
| 0A48A26E2508B57F0036A529 /* Embed App Clips */, | ||
| 3B06AD1E1E4923F5004D2608 /* Thin Binary */, |
There was a problem hiding this comment.
Rearrange these to avoid a cycle error caused by Runner.app/Info.plist:
Cycle inside Runner; building could produce unreliable results.
Cycle details:
→ Target 'Runner' has copy command from 'Runner.app/AppClips/AppClip.app'
○ That command depends on command in Target 'Runner': script phase “Thin Binary”
○ Target 'Runner' has process command with output 'Runner.app/Info.plist'
○ Target 'Runner' has copy command from 'Runner.app/AppClips/AppClip.app'
| CODE_SIGN_STYLE = Automatic; | ||
| DEVELOPMENT_TEAM = ""; | ||
| ENABLE_BITCODE = NO; | ||
| FRAMEWORK_SEARCH_PATHS = ( |
There was a problem hiding this comment.
I removed this instructions from https://docs.flutter.dev/platform-integration/ios/ios-app-clip#step-7---integrate-flutter in flutter/website#10145, it's not necessary.
| GCC_WARN_UNUSED_FUNCTION = YES; | ||
| GCC_WARN_UNUSED_VARIABLE = YES; | ||
| IPHONEOS_DEPLOYMENT_TARGET = 9.0; | ||
| IPHONEOS_DEPLOYMENT_TARGET = 16.0; |
There was a problem hiding this comment.
Take advantage of 16.0 15MB App Clip size limit.
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <Scheme | ||
| LastUpgradeVersion = "1020" | ||
| LastUpgradeVersion = "1530" |
| import Flutter | ||
|
|
||
| @UIApplicationMain | ||
| @main |
There was a problem hiding this comment.
Avoid UIApplicationMain deprecation flutter/flutter#143044
| <!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd"> | ||
| <plist version="1.0"> | ||
| <dict> | ||
| <key>CADisableMinimumFrameDurationOnPhone</key> |
There was a problem hiding this comment.
Automigrations from flutter.
|
Are you ready for this PR to land? |
Yup, thanks for reviewing, I wasn't sure who else to put as a reviewer. I'll merge (this wouldn't have caused the android-build failure, should I file a bug?) |
flutter runon the project to pick up project automigrations.First introduced in #538
See also flutter/website#10145
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-devrel channel on Discord.