Skip to content

Bump zulip test to e0dff1e7aa94049b96048c2204d26debe3dc6785 - #450

Merged
QuncCccccc merged 1 commit into
mainfrom
pick_up_first_commit_of_zulip
Mar 28, 2025
Merged

Bump zulip test to e0dff1e7aa94049b96048c2204d26debe3dc6785#450
QuncCccccc merged 1 commit into
mainfrom
pick_up_first_commit_of_zulip

Conversation

@QuncCccccc

@QuncCccccc QuncCccccc commented Mar 27, 2025 •
edited by gnprice
Loading

Copy link
Copy Markdown
Contributor

This is to fix the customer testing in flutter/flutter#165596
by picking up zulip/zulip-flutter#1443

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read the [Flutter Style Guide] recently, and have followed its advice.
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@QuncCccccc QuncCccccc mentioned this pull request Mar 27, 2025
Merged
@QuncCccccc
QuncCccccc requested a review from gnprice March 27, 2025 19:19
@auto-submit auto-submit Bot removed the autosubmit label Mar 27, 2025
@auto-submit

auto-submit Bot commented Mar 27, 2025

Copy link
Copy Markdown
Contributor

autosubmit label was removed for flutter/tests/450, because - The status or check suite linux_tests (shard 1 of 3, 0) has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit Bot removed the autosubmit label Mar 27, 2025
@auto-submit

auto-submit Bot commented Mar 27, 2025

Copy link
Copy Markdown
Contributor

autosubmit label was removed for flutter/tests/450, because - The status or check suite linux_tests (shard 1 of 3, 0) has failed. Please fix the issues identified (or deflake) before re-applying this label.

@QuncCccccc

QuncCccccc commented Mar 28, 2025

Copy link
Copy Markdown
Contributor Author

@gnprice Have you seen this failure before? I tried to rerun it but still failed.

@gnprice

gnprice commented Mar 28, 2025

Copy link
Copy Markdown
Member

I haven't. Here's the start of the errors:

| ✅ /tmp/flutter_customer_testing.flutter_devtools.GGECGD/tests/packages/devtools_app_shared/test/service/flutter_version_test.dart: FlutterVersion parses dart version correctly
|
| 🎉 101 tests passed.
| Resolving dependencies in `/tmp/flutter_customer_testing.flutter_devtools.GGECGD/tests`...
| Downloading packages...
|   _fe_analyzer_shared 76.0.0 (80.0.0 available)
|   analyzer 6.11.0 (7.3.0 available)
|   dart_style 2.3.8 (3.0.1 available)
|   intl 0.19.0 (0.20.2 available)
|   material_color_utilities 0.11.1 (0.12.0 available)
|   source_gen 1.5.0 (2.0.0 available)
| Got dependencies in `/tmp/flutter_customer_testing.flutter_devtools.GGECGD/tests`!
| 6 packages have newer versions incompatible with dependency constraints.
| Try `flutter pub outdated` for more information.
| Resolving dependencies in `/tmp/flutter_customer_testing.flutter_devtools.GGECGD/tests`...
| Downloading packages...
|   _fe_analyzer_shared 76.0.0 (80.0.0 available)
|   analyzer 6.11.0 (7.3.0 available)
|   dart_style 2.3.8 (3.0.1 available)
|   intl 0.19.0 (0.20.2 available)
|   material_color_utilities 0.11.1 (0.12.0 available)
|   source_gen 1.5.0 (2.0.0 available)
| Got dependencies in `/tmp/flutter_customer_testing.flutter_devtools.GGECGD/tests`!
| 6 packages have newer versions incompatible with dependency constraints.
| Try `flutter pub outdated` for more information.
|
| /home/runner/.pub-cache/hosted/pub.dev/vm_service_protos-1.1.0/lib/src/protos/perfetto/trace/clock_snapshot.pb.dart:104:26: Error: The method '$_clearField' isn't defined for the class 'ClockSnapshot_Clock'.
|  - 'ClockSnapshot_Clock' is from 'package:vm_service_protos/src/protos/perfetto/trace/clock_snapshot.pb.dart' ('/home/runner/.pub-cache/hosted/pub.dev/vm_service_protos-1.1.0/lib/src/protos/perfetto/trace/clock_snapshot.pb.dart').
| Try correcting the name to the name of an existing method, or defining a method named '$_clearField'.
|   void clearClockId() => $_clearField(1);
|                          ^^^^^^^^^^^^

So it seems like it's in the flutter_devtools test. The #hackers-devtools Discord channel would probably be a good place to ask.

Seems like the failure must be somehow caused out-of-band, because the failing shard isn't even the one that ran the Zulip test (the one this PR updates). Up toward the top of the log in this failing shard, it says:

++ /home/runner/work/tests/tests/flutter/bin/dart /home/runner/work/tests/tests/flutter/dev/customer_testing/run_tests.dart --shards 3 --shard-index 0 --skip-template --repeat=15 --verbose registry/assorted_layout_widgets.test registry/dart_rfb.test registry/flutter_cocoon.test registry/flutter_devtools.test registry/flutter_devtools_analysis.test registry/flutter_packages.test registry/flutter_portal.test registry/flutter_rfb.test registry/macos_ui.test registry/patrol.test registry/provider.test registry/super_editor.test registry/super_sliver_list.test registry/template.test registry/zulip.test
Starting run_tests.dart...
14 files specified. 5 tests in shard #0 (3 shards total).

Tests in this shard:
./registry/assorted_layout_widgets.test
./registry/flutter_devtools.test
./registry/flutter_portal.test
./registry/patrol.test
./registry/super_sliver_list.test

@gnprice

gnprice commented Mar 28, 2025

Copy link
Copy Markdown
Member

One background fact about this repo's CI is that it runs in a different environment from when the same tests run in the flutter/flutter CI: this one runs in GitHub Actions, while flutter/flutter runs the same tests in LUCI.

So it's possible that these same flutter_devtools tests are passing fine when they run in the flutter/flutter CI. That wouldn't be the first time that test behavior has diverged between the two environments: flutter/flutter#162041 (comment). But as long as that is the way the infra works, we should get the tests fixed so they pass in both environments.

@jason-simmons

jason-simmons commented Mar 28, 2025

Copy link
Copy Markdown
Member

vm_service_protos version 1.1.0 contained generated protobuf classes that were incompatible with the latest published version of the protobuf package.

That version of vm_service_protos has been retracted (see https://pub.dev/packages/vm_service_protos/versions)

Try rerunning the tests. Pub should now select vm_service_protos version 1.0.0 and avoid this error.

@QuncCccccc
QuncCccccc merged commit 8be7209 into main Mar 28, 2025
@QuncCccccc
QuncCccccc deleted the pick_up_first_commit_of_zulip branch March 28, 2025 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gnprice gnprice gnprice approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@QuncCccccc @gnprice @jason-simmons