Skip to content

Remove bitcode references #7748

Closed
Closed
Remove bitcode references#7748
Labels
e1-hoursEffort: < 8 hrsp2-mediumNecessary but not urgent concern. Resolve when possible.target.iOSTarget apps on the iOS Platform

Description

@jmagman
jmagman
opened on Nov 10, 2022

Page URL

https://docs.flutter.dev/resources/faq#how-big-is-the-flutter-engine

Page source

No response

Describe the problem

Some notes that bitcode is being removed were added as part of #7623.

Expected fix

Remove references to bitcode once flutter/flutter#112831 (available in 3.4.0-37.0.pre) is in stable. Includes the "The release engine binary includes LLVM IR (bitcode)" paragraph in https://docs.flutter.dev/resources/faq#how-big-is-the-flutter-engine

Additional context

Part of flutter/flutter#107887

Activity

  1. danagbemava-nc
    added
    st.triage.triage-teamTriage team reviewing and categorizing the issue
    p2-mediumNecessary but not urgent concern. Resolve when possible.
    e1-hoursEffort: < 8 hrs
    os:iOS
    and removed
    st.triage.triage-teamTriage team reviewing and categorizing the issue
    on Nov 11, 2022

  2. sfshaza2 commented on Nov 11, 2022

    @sfshaza2
    sfshaza2
    on Nov 11, 2022
    Contributor

    Yes, bitcode is deprecated. In fact, the second-to-last paragraph ends with the following sentence: "Note bitcode has been deprecated and will be removed from Flutter in a future release." Assuming that it's ok with @jmagman, I'd be fine with deleting this paragraph, but maybe keeping the note. Though it should be put in an official liquid note format.

  3. jmagman commented on Nov 14, 2022

    @jmagman
    jmagman
    on Nov 14, 2022
    MemberAuthor

    Yes, bitcode is deprecated. In fact, the second-to-last paragraph ends with the following sentence: "Note bitcode has been deprecated and will be removed from Flutter in a future release."

    I added that in #7623

    Assuming that it's ok with @jmagman, I'd be fine with deleting this paragraph, but maybe keeping the note. Though it should be put in an official liquid note format.

    My suggestion was to wait until flutter/flutter#112831 (available in 3.4.0-37.0.pre) is in stable. Once that happens we don't even need the note.

  4. sfshaza2 commented on Nov 14, 2022

    @sfshaza2
    sfshaza2
    on Nov 14, 2022
    Contributor

    SG!

  5. jmagman commented on Feb 8, 2023

    @jmagman
    jmagman
    on Feb 8, 2023
    MemberAuthor

    This is complete, thanks @sfshaza2! https://github.com/flutter/website-private/pull/130

  6. jmagman
    closed this as completedon Feb 8, 2023
  7. atsansone
    added
    target.iOSTarget apps on the iOS Platform
    and removed
    os:iOS
    on May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    e1-hoursEffort: < 8 hrsp2-mediumNecessary but not urgent concern. Resolve when possible.target.iOSTarget apps on the iOS Platform

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions