Skip to content

Add breaking change doc for isFocusable - #12159

Merged
sfshaza2 merged 2 commits into
flutter:mainfrom
hannah-hyj:focusable
Sep 25, 2025
Merged

sfshaza2 merged 2 commits into
flutter:mainfrom
hannah-hyj:focusable

Conversation

@hannah-hyj

Copy link
Copy Markdown
Member

Description of what this PR is changing or adding, and why:

Issues fixed by this PR (if any):

PRs or commits this PR depends on (if any):

Presubmit checklist

  • This PR is marked as draft with an explanation if not meant to land until a future stable release.
  • This PR doesn’t contain automatically generated corrections (Grammarly or similar).
  • This PR follows the Google Developer Documentation Style Guidelines — for example, it doesn’t use i.e. or e.g., and it avoids I and we (first person).
  • This PR uses semantic line breaks of 80 characters or fewer.

@flutter-website-bot

flutter-website-bot commented Jun 27, 2025 •

Copy link
Copy Markdown
Collaborator

Visit the preview URL for this PR (updated for commit a7fa637):

https://flutter-docs-prod--pr12159-focusable-d7a754zs.web.app

@sfshaza2 sfshaza2 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor updates and one question.

Comment thread src/content/release/breaking-changes/deprecate-focusable.md Outdated
Comment thread src/content/release/breaking-changes/deprecate-focusable.md Outdated
Comment thread src/content/release/breaking-changes/deprecate-focusable.md Outdated
Comment thread src/content/release/breaking-changes/deprecate-focusable.md Outdated
Comment thread src/content/release/breaking-changes/deprecate-focusable.md Outdated
Comment thread src/content/release/breaking-changes/deprecate-focusable.md Outdated
Comment thread src/content/release/breaking-changes/deprecate-focusable.md Outdated
Comment thread src/content/release/breaking-changes/deprecate-focusable.md Outdated
Comment thread src/content/release/breaking-changes/deprecate-focusable.md
@sfshaza2 sfshaza2 added the review.await-update Awaiting Updates after Edits label Jun 29, 2025
Comment thread src/content/release/breaking-changes/deprecate-focusable.md
Comment thread src/content/release/breaking-changes/deprecate-focusable.md Outdated
@sfshaza2

sfshaza2 commented Jul 7, 2025

Copy link
Copy Markdown
Contributor

@hannah-hyj, please ping me when this is ready to land

@Piinks

Piinks commented Sep 15, 2025

Copy link
Copy Markdown
Contributor

Greetings from stale PR triage! 👋
Is this change still on your radar?

@hannah-hyj

Copy link
Copy Markdown
Member Author

yes! this is still on my radar.

hannah-hyj and others added 2 commits September 17, 2025 11:46
resolve comments

Update src/content/release/breaking-changes/deprecate-focusable.md

Update src/content/release/breaking-changes/deprecate-focusable.md

Update src/content/release/breaking-changes/deprecate-focusable.md

Update src/content/release/breaking-changes/deprecate-focusable.md

Update deprecate-focusable.md

Update deprecate-focusable.md

add doc

Co-Authored-By: Shams Zakhour (ignore Sfshaza) <[email protected]>
@hannah-hyj

Copy link
Copy Markdown
Member Author

@sfshaza2 this PR is ready

@sfshaza2 sfshaza2 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sfshaza2
sfshaza2 merged commit daa2c75 into flutter:main Sep 25, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review.await-update Awaiting Updates after Edits

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants