Skip to content

Update instructions to install CocoaPods version 1.7.5 - #3041

Merged
sfshaza2 merged 2 commits into
flutter:masterfrom
jmagman:pod-version
Sep 28, 2019
Merged

sfshaza2 merged 2 commits into
flutter:masterfrom
jmagman:pod-version

Conversation

@jmagman

@jmagman jmagman commented Sep 27, 2019

Copy link
Copy Markdown
Member

Temporary note to install CocoaPods 1.7.5 until flutter/flutter#41253 makes it to stable.

@googlebot googlebot added the cla: yes Contributor has signed the Contributor License Agreement label Sep 27, 2019
@jmagman

jmagman commented Sep 27, 2019

Copy link
Copy Markdown
Member Author

@zanderso

@jmagman
jmagman removed the request for review from christopherfujino September 27, 2019 19:05
@christopherfujino
christopherfujino requested review from christopherfujino and removed request for christopherfujino September 27, 2019 20:06

@christopherfujino christopherfujino left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfshaza2 sfshaza2 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @jmagman! Just a few tweaks.

$ sudo gem install cocoapods -v 1.7.5
$ pod setup
```
{{site.alert.warning}} Versions of CocoaPods greater than 1.7.5 are not compatible with the most recent stable version of Flutter. See [this issue](https://github.com/flutter/flutter/issues/41253) for details and a forthcoming fix. {{site.alert.end}}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you break up the lines so that each line no more than 80 chars? Also, indent the lines inside the warning by two spaces per line. Also, the link text must be more descriptive, which is an accessibility requirement. We use macros for GitHub links. Finally, I think a note (green) is sufficient for this text, rather than a warning (yellow).

How about this:

{{site.alert.note}}
The pod setup command fails for versions of CocoaPods greater
than 1.7.5. For more information, see issue 41252.
{{site.alert.end}}

@jmagman

jmagman commented Sep 28, 2019

Copy link
Copy Markdown
Member Author

Waiting on @sfshaza2

@sfshaza2

Copy link
Copy Markdown
Contributor

@jmagman, I don't see my feedback incorporated?

@jmagman

jmagman commented Sep 28, 2019

Copy link
Copy Markdown
Member Author

@jmagman, I don't see my feedback incorporated?

I totally missed it, apologies!

@sfshaza2

Copy link
Copy Markdown
Contributor

The link text is missing, but I'll go ahead and merge this and fix it in a followup PR.

@sfshaza2
sfshaza2 merged commit 0f82f7e into flutter:master Sep 28, 2019
@jmagman
jmagman deleted the pod-version branch August 6, 2021 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Contributor has signed the Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants