Skip to content

Add .android note to add-to-app project setup page - #3454

Merged
sfshaza2 merged 1 commit into
flutter:masterfrom
jmagman:android-dir
Dec 19, 2019
Merged

sfshaza2 merged 1 commit into
flutter:masterfrom
jmagman:android-dir

Conversation

@jmagman

@jmagman jmagman commented Dec 19, 2019 •

Copy link
Copy Markdown
Member

Add note that .android/ should not be edited to match .ios/ note.

See flutter/flutter#32883

Fixes flutter/flutter#32992.

@jmagman
jmagman requested review from sfshaza2 and xster December 19, 2019 00:39
@jmagman jmagman self-assigned this Dec 19, 2019
@googlebot googlebot added the cla: yes Contributor has signed the Contributor License Agreement label Dec 19, 2019
@@ -97,6 +97,13 @@ This creates a `some/path/my_flutter/` Flutter module project with some Dart
code to get you started and a `.android/` hidden subfolder that wraps up the

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xster Is this specific enough to satisfy flutter/flutter#32992?

@xster xster left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@sfshaza2 sfshaza2 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but won't merge until @xster reviews.

@sfshaza2
sfshaza2 merged commit 8bb925d into flutter:master Dec 19, 2019
@jmagman
jmagman deleted the android-dir branch December 19, 2019 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Contributor has signed the Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Better document the module project's platform host project purpose

4 participants