Skip to content

Update assets-and-images.md - #352

Merged
LarkAscending merged 5 commits into
masterfrom
LarkAscending-assets-images
Jan 18, 2017
Merged

LarkAscending merged 5 commits into
masterfrom
LarkAscending-assets-images

Conversation

@LarkAscending

Copy link
Copy Markdown
Contributor
  1. Updating link from ImageResource to newer ImageStream class (see flutter/flutter@2dfdc84)
  2. Updating link from AssetVendor to newer AssetImage.
  3. Removing reference to resolution_awareness.dart - there is no replacement example.
  4. Adding "assets/" prefix to path in build method in Loading Images.

Partial fix for flutter/flutter#7480

1. Updating link from ImageResource to newer ImageStream class (see flutter/flutter@2dfdc84)
2. Updating link from AssetVendor to newer AssetImage.
3. Removing reference to resolution_awareness.dart - there is no replacement example.
4. Adding "assets/" prefix to path in build method in Loading Images.
@LarkAscending LarkAscending self-assigned this Jan 13, 2017
@googlebot googlebot added the cla: yes Contributor has signed the Contributor License Agreement label Jan 13, 2017
@sethladd

Copy link
Copy Markdown
Contributor

lgtm

thank you!

Comment thread assets-and-images.md Outdated
The way this works is through an object called
[`AssetVendor`](https://docs.flutter.io/flutter/widgets/AssetVendor-class.html)
[`AssetImage`](https://docs.flutter.io/flutter/widgets/AssetImage-class.html)
established at the top of the build tree. AssetVendor replaces the default asset

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this whole paragraph is wrong now (AssetVendor was entirely removed).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good one!

Trying to say nothing incorrect about using assets, as an incremental step toward helpful and complete documentation.
1. Commenting or replacing everything to do with obsolete AssetVendor.
2. Adding an untested DefaultAssetBundle.of code sample, since we recommend this approach.
@LarkAscending

Copy link
Copy Markdown
Contributor Author

See flutter/flutter#7530 for future work needed on this page.

@LarkAscending
LarkAscending deleted the LarkAscending-assets-images branch February 17, 2017 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Contributor has signed the Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants