Repository navigation
Migration guide for flutter/flutter#49389 - #3622
Merged
Merged
Conversation
googlebot
added
the
cla: yes
11 of 13 tasks
goderbauer
reviewed
Jan 29, 2020
| @@ -0,0 +1,140 @@ | |||
| --- | |||
| title: [Changes to ImageCache and ImageProvider] | |||
Member
There was a problem hiding this comment.
are these supposed to be in []? The one other guide I checked didn't have that...
| ## Summary | ||
|
|
||
| `ImageCache` now has a method called `obaintsKey`. `ImageProvider` subclasses | ||
| should not override `resolve`, but instead should resolve new methods on |
Member
There was a problem hiding this comment.
should resolve -> should implement
or something like that?
| ... | ||
| } | ||
| ``` | ||
|
|
Member
There was a problem hiding this comment.
Is this missing a "Code after the migration:"?
|
|
||
| ## Timeline | ||
|
|
||
| TBD - will update before landing |
sfshaza2
reviewed
Jan 30, 2020
sfshaza2
left a comment
sfshaza2
left a comment
Contributor
There was a problem hiding this comment.
Looks good, once you add the release info!
|
|
||
| ## Summary | ||
|
|
||
| `ImageCache` now has a method called `obaintsKey`. `ImageProvider` subclasses |
Contributor
There was a problem hiding this comment.
obaintsKey => containsKey. ??
Contributor
Author
There was a problem hiding this comment.
Whups. Yes. There is also a method calld obtainKey, must've had a brain fart in there haha
Contributor
Author
|
Added release info. |
|
when they move this to stable branch? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For what it's worth, I have not been able to find any instances of people overriding
ImageProvider.resolvein google3 or pub.This is combined because the upstream change is combined. Before landing I will change the TBD to actually have the Flutter version it lands in.