Repository navigation
migration guide for ColoredBox/container optimization - #3728
Merged
Merged
Conversation
googlebot
added
the
cla: yes
9 tasks done
sfshaza2
requested changes
Feb 24, 2020
sfshaza2
left a comment
sfshaza2
left a comment
Contributor
There was a problem hiding this comment.
Thanks for this PR! Once we have an actual release, and it's added, we can merge.
| Previously, this code would result in a widget heirarchy that used a | ||
| `BoxDecoration` to actually paint the background color. The `BoxDecoration` | ||
| widget covers many cases other than just painting a background color, and is | ||
| not as efficient as the new `ColoredBox` widget which only paints a background |
Contributor
There was a problem hiding this comment.
widget which => widget, which
|
|
||
| Widget tests that wanted to assert based on the color of a container in the | ||
| widget tree would previously have to find the `BoxDecoration` to actually get | ||
| the color of the container. Now, they will be able to check the `color` property |
Contributor
There was a problem hiding this comment.
now they will be => now they are
|
|
||
| ## Timeline | ||
|
|
||
| This change was introduced in v1.TBD |
Contributor
There was a problem hiding this comment.
We no longer merge breaking changes until they have landed.
Contributor
Author
There was a problem hiding this comment.
Right - I'll update this once the change has actually landed and I have a version number
| Relevant PRs: | ||
| * [Colored box and container optimization #50979][] | ||
|
|
||
| {% comment %} |
Contributor
There was a problem hiding this comment.
Please remove the comment markers and the text that introduces them. thx
Contributor
Author
|
Resolved the merge conflict and updated the version number. @sfshaza2 PTAL |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
flutter/flutter#50979