Skip to content

Fix breaking change - #530

Merged
sethladd merged 11 commits into
masterfrom
mit-mit-boxdeco
Apr 28, 2017
Merged

Fix breaking change#530
sethladd merged 11 commits into
masterfrom
mit-mit-boxdeco

Conversation

@mit-mit

@mit-mit mit-mit commented Apr 28, 2017

Copy link
Copy Markdown
Member

Update backgroundColor -> color to match flutter/flutter#9648

@mit-mit
Fix breaking change
f5ed90a 
Update backgroundColor -> color to match flutter/flutter#9648
@googlebot googlebot added the cla: yes Contributor has signed the Contributor License Agreement label Apr 28, 2017
@mit-mit mit-mit mentioned this pull request Apr 28, 2017
Merged
@mit-mit

mit-mit commented Apr 28, 2017

Copy link
Copy Markdown
Member Author

Fixes travis failure:

https://travis-ci.org/flutter/website/builds/226718731

Analyzing /home/travis/build/flutter/website/_includes/_code/container/main.dart...
  warning • The named parameter 'backgroundColor' isn't defined at _includes/_code/container/main.dart:41:9 • undefined_named_parameter
1 issue found.
(Ran in 5.6s)

@sethladd

sethladd commented Apr 28, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

Looks like we need to update backgroundImage, too.

I'm on the case.

@FlutterBot

FlutterBot commented Apr 28, 2017

Copy link
Copy Markdown

Staging URL Generated At https://flutter-io-deploy-four.firebaseapp.com . Please allow Travis Build to finish to view the URL.

@sethladd

sethladd commented Apr 28, 2017

Copy link
Copy Markdown
Contributor

lgtm

@sethladd
sethladd merged commit eb247f1 into master Apr 28, 2017
@sethladd
sethladd deleted the mit-mit-boxdeco branch April 28, 2017 17:53
@sethladd sethladd mentioned this pull request Apr 28, 2017
Closed
Hixie
Hixie reviewed Apr 28, 2017
View reviewed changes
Comment thread _includes/_code/container/main.dart
var container = new Container(
decoration: new BoxDecoration(
backgroundColor: Colors.black26,
color: Colors.black26,

@Hixie Hixie Apr 28, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For cases like this where there's a BoxDecoration with nothing but a color, in a Container, you can replace the decoration property with a color property that just takes the Color and avoid the BoxDecoration entirely.

@Hixie Hixie Apr 28, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This applies to most cases here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Hixie Hixie Hixie left review comments

Assignees

No one assigned

Labels

cla: yes Contributor has signed the Contributor License Agreement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mit-mit @sethladd @FlutterBot @Hixie @googlebot