Skip to content

Add info on how to edit plugin projects - #561

Merged
mravn-google merged 3 commits into
masterfrom
edit-plugin-project
May 16, 2017
Merged

mravn-google merged 3 commits into
masterfrom
edit-plugin-project

Conversation

@mravn-google

@mravn-google mravn-google commented May 16, 2017 •

Copy link
Copy Markdown
Contributor

@googlebot googlebot added the cla: yes Contributor has signed the Contributor License Agreement label May 16, 2017
@FlutterBot

Copy link
Copy Markdown

Staging URL Generated At https://flutter-io-deploy-two.firebaseapp.com . Please allow Travis Build to finish to view the URL.

@jakobr-google jakobr-google left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LVGTM. Thanks!

@roughike

Copy link
Copy Markdown
Contributor

@mravn-google
Please see this comment I made on the issue ticket and consider making documentation for that part too. It took me a long time to get it figured out, and I expect it's not that easy to figure out for others as well.

flutter/flutter#9698 (comment)

Seems to avoid some spurious compile errors in Xcode that go away once Xcode has had a change to build the app.

@jakobr-google jakobr-google left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SLVGTM

@szakarias szakarias left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mravn-google
mravn-google merged commit fba98c0 into master May 16, 2017
@mravn-google

Copy link
Copy Markdown
Contributor Author

cc @branflake2267

@mit-mit
mit-mit deleted the edit-plugin-project branch May 16, 2017 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Contributor has signed the Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants