Insert content text input client breaking change by tneotia · Pull Request #7692 · flutter/website

tneotia · 2022-10-25T18:08:00Z

Description of what this PR is changing or adding, and why:

This adds a migration guide for the new member of TextInputClient added by flutter/flutter#110052

Issues fixed by this PR (if any): Fixes #ISSUE-NUMBER

Presubmit checklist

This PR doesn’t contain automatically generated corrections (Grammarly or similar).
This PR follows the Google Developer Documentation Style Guidelines — for example, it doesn’t use i.e. or e.g., and it avoids I and we (first person).
This PR uses semantic line breaks of 80 characters or fewer.

justinmc

LGTM from a technical standpoint. I added some suggestions of details that could be added, but I think it's up to you.

Also just stating that this PR should wait until the framework PR is merged and then be updated with the version it landed in.

atsansone

@tneotia : A little bit of language tweaking. LGTM after those changes.

LongCatIsLooong · 2022-12-03T01:36:39Z

Hi @atsansone could you take another look?

justinmc · 2022-12-05T22:29:30Z

And @tneotia can you update the branch with main?

…-input-client

tneotia · 2022-12-05T22:43:46Z

@justinmc done

tneotia · 2022-12-14T16:33:45Z

Hi, any movement with this? Do I need to mark this as ready to review? (I was under the assumption that the PR in the SDK repo needs to be merged first, but maybe this is the holdup instead?)

sfshaza2

Thanks so much for this breaking change, @tneotia! I had a few minor nits and I can't land this without actual links and the "landed in" info. For the. missing API link, perhaps you could use a link to the master docs repo? The template explains this, but the link looks something like: {{site.master-api}}/flutter/[link_to_relevant_page].html.

sfshaza2 · 2022-12-30T18:20:16Z

P.S. This PR would not hold up the PR on the flutter engine repo.

sfshaza2 · 2022-12-30T18:20:47Z

Also, when this PR is ready to land, remove it from the Draft state.

sfshaza2 · 2023-01-09T22:07:20Z

@tneotia, can we move this out of draft state and land? We are freezing the website by end of day today. Otherwise we will just close it and it can be reopened later.

sfshaza2 · 2023-01-09T22:32:10Z

Closing for now.

tneotia · 2023-01-09T22:36:19Z

The PR on Flutter SDK has not been merged yet so your review criteria wouldn't be satisfied. Hoping that it is revisited soon, then I'll reopen this :)

sfshaza2 · 2023-01-09T22:41:45Z

Sounds good!

…

On Mon, Jan 9, 2023 at 2:36 PM Tanay Neotia ***@***.***> wrote: The PR on Flutter SDK has not been merged yet so your review criteria wouldn't be satisfied. Hoping that it is revisited soon, then I'll reopen this :) — Reply to this email directly, view it on GitHub <#7692 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKS4PKMABCOX7S2EWMJWACLWRSHG5ANCNFSM6AAAAAAROHBUHY> . You are receiving this because you modified the open/close state.Message ID: ***@***.***>

justinmc · 2023-02-02T19:08:24Z

Reopening because the PR has landed and has been tagged with v3.8.0-1.0.pre (merge commit). @tneotia Could you add that version into this PR where you put TBDs?

…-input-client # Conflicts: # src/release/breaking-changes/index.md

tneotia · 2023-03-17T19:05:40Z

@atsansone should be good now :)

domesticmouse · 2023-03-17T20:25:08Z

@sfshaza2 and @atsansone can you verify that your requested changes have been appropriately landed, thanks!

atsansone

Needs a few tweaks, then I can approve.

…-input-client # Conflicts: # src/release/breaking-changes/index.md

tneotia · 2023-04-03T21:33:47Z

@atsansone should be good to go now

parlough

Thanks for documenting this.

Two small changes now that this has landed:

Co-authored-by: Parker Lougheed <[email protected]>

parlough

Thanks for making those adjustments!

Changes addressed, reviewer OOO

Hixie · 2023-05-16T18:36:42Z

I had a conflict with this in my PR and I'm not sure I merged it correctly, can someone check https://github.com/flutter/website/pull/8683/files is correct?

parlough · 2023-05-16T18:41:18Z

Yep. I checked and pushed fixes for it.

Add insert-content-text-input-client.md

d812ecc

tneotia mentioned this pull request Oct 25, 2022

Add support for image insertion on Android flutter/flutter#110052

Merged

8 tasks done

atsansone assigned johnpryan and unassigned johnpryan Oct 25, 2022

atsansone requested a review from justinmc October 25, 2022 18:51

atsansone assigned justinmc Oct 25, 2022

atsansone added the review.tech Awaiting Technical Review label Oct 25, 2022

justinmc approved these changes Oct 25, 2022

View reviewed changes

Comment thread src/release/breaking-changes/insert-content-text-input-client.md

atsansone suggested changes Oct 26, 2022

View reviewed changes

Comment thread src/release/breaking-changes/insert-content-text-input-client.md Outdated

Comment thread src/release/breaking-changes/insert-content-text-input-client.md Outdated

Comment thread src/release/breaking-changes/insert-content-text-input-client.md Outdated

Tweak language and add more suggestions for developers

53b6292

tneotia requested a review from atsansone November 16, 2022 16:35

Merge remote-tracking branch 'upstream/main' into insert-content-text…

8074ace

…-input-client

Merge branch 'main' into insert-content-text-input-client

74ec9c7

sfshaza2 previously requested changes Dec 30, 2022

View reviewed changes

sfshaza2 closed this Jan 9, 2023

justinmc reopened this Feb 2, 2023

tneotia added 2 commits February 2, 2023 15:38

Merge remote-tracking branch 'upstream/main' into insert-content-text…

ee25fcd

…-input-client # Conflicts: # src/release/breaking-changes/index.md

Fix nits and add landed version & docs link

b427b76

tneotia marked this pull request as ready for review February 2, 2023 20:53

Merge branch 'main' into insert-content-text-input-client

8fcb06c

atsansone previously requested changes Apr 3, 2023

View reviewed changes

atsansone added review.await-update Awaiting Updates after Edits and removed review.copy Awaiting Copy Review labels Apr 3, 2023

atsansone assigned tneotia and unassigned justinmc Apr 3, 2023

tneotia added 2 commits April 3, 2023 17:31

Fix nits and grammatical issues

67c6093

Merge remote-tracking branch 'upstream/main' into insert-content-text…

42d562d

…-input-client # Conflicts: # src/release/breaking-changes/index.md

tneotia requested a review from atsansone April 3, 2023 21:34

gnprice mentioned this pull request Apr 7, 2023

Error messages immediately after an upgrade should mention flutter downgrade flutter/flutter#124151

Closed

sfshaza2 added st.RFM Ready to merge or land act.merge-to-next Merge PR to next stable branch release and removed review.await-update Awaiting Updates after Edits labels Apr 26, 2023

Merge branch 'main' into insert-content-text-input-client

561ad83

parlough approved these changes May 12, 2023

View reviewed changes

Comment thread src/release/breaking-changes/insert-content-text-input-client.md Outdated

Comment thread src/release/breaking-changes/insert-content-text-input-client.md Outdated

parlough added st.RFM.% Ready to merge or land with minor changes. No further review needed. and removed st.RFM Ready to merge or land act.merge-to-next Merge PR to next stable branch release labels May 12, 2023

tneotia and others added 3 commits May 12, 2023 17:52

Change from master to standard

f7e7927

Co-authored-by: Parker Lougheed <[email protected]>

Add stable release version

1aae736

Co-authored-by: Parker Lougheed <[email protected]>

Merge branch 'main' into insert-content-text-input-client

eb6400e

parlough approved these changes May 14, 2023

View reviewed changes

parlough merged commit de22b96 into flutter:main May 14, 2023

Conversation

tneotia commented Oct 25, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Presubmit checklist

Uh oh!

justinmc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

atsansone left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

LongCatIsLooong commented Dec 3, 2022

Uh oh!

justinmc commented Dec 5, 2022

Uh oh!

tneotia commented Dec 5, 2022

Uh oh!

tneotia commented Dec 14, 2022

Uh oh!

sfshaza2 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sfshaza2 commented Dec 30, 2022

Uh oh!

sfshaza2 commented Dec 30, 2022

Uh oh!

sfshaza2 commented Jan 9, 2023

Uh oh!

sfshaza2 commented Jan 9, 2023

Uh oh!

tneotia commented Jan 9, 2023

Uh oh!

sfshaza2 commented Jan 9, 2023 via email

Uh oh!

justinmc commented Feb 2, 2023

Uh oh!

tneotia commented Mar 17, 2023

Uh oh!

domesticmouse commented Mar 17, 2023

Uh oh!

atsansone left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tneotia commented Apr 3, 2023

Uh oh!

parlough left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

parlough left a comment

Choose a reason for hiding this comment

Uh oh!

Hixie commented May 16, 2023

Uh oh!

parlough commented May 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

tneotia commented Oct 25, 2022 •

edited

Loading

parlough commented May 16, 2023 •

edited

Loading