Repository navigation
Adding info on iOS app extensions - #8265
Conversation
Hey Leigha, can you add me to the codelab docs? Also, I'm curious if you plan to add the code for said codelabs to https://github.com/flutter/codelabs? FYI @sfshaza2 |
Co-authored-by: Shams Zakhour (ignore Sfshaza) <[email protected]>
|
FYI @atsansone and @sfshaza2 -- I made a few updates based on the feedback and a conversation I had with @jmagman yesterday. Feel free to take another look and let me know if you want further changes. Instead of creating two codelabs, only one will be referenced in this doc. The other, I just put the steps directly in the doc since this isn't a fully supported workflow. Also, I needed to change the images to HTML to get the correct sizing indentation. Feel free to propose an alternative. @atsansone if you update anything can you leave it as a suggestion so I can make sure that it's all good from a technical perspective? I noticed you added the commit directly to this branch in the last iteration. Thank you!! :) |
atsansone
left a comment
atsansone
left a comment
There was a problem hiding this comment.
@leighajarett : Some comments should be addressed (issue), even if it's just to say Acknowledged. The others are up to you.
Thanks!
Co-authored-by: Anthony Sansone <[email protected]>
|
@atsansone and @jmagman I've gone through all your comments and made adjustments. Feel free to take another look! |
There was a problem hiding this comment.
LGTM once @sfshaza2 and @atsansone are happy. Thanks again for doing this!
atsansone
added
st.RFM
|
@leighajarett, we can't merge this PR until it passes all tests. The linkcheck is failing because the page includes this link: |
sfshaza2
left a comment
sfshaza2
left a comment
There was a problem hiding this comment.
Commented out a not-yet-available codelab, fixed a malformed link, indented a note. With these fixes, the CI should build and this can be merged.
|
@leighajarett Where can I find the iOS app extension codelab? Or where can I follow its development? I can't currently find it in the available Flutter codelabs. |
6 participants
Description of what this PR is changing or adding, and why:
This adds a new page that describes how Flutter developers can add iOS app extensions. This is a popular feature request: flutter/flutter#16092. It also adds a few plugins to the existing page that talks about Apple system libraries.
I am submitting this now to get the review started, but we shouldn't publish it until we have published the two codelabs (I am currently working on them and hoping to have a draft ready in the next few weeks) and this PR is merged: flutter-team-archive/plugins#7114
I couldn't figure out how to get the images to be a bit smaller, or how to fix the numbered list with an image -- if anyone knows how to fix this that would be amazing!
Issues fixed by this PR (if any): #7448
Presubmit checklist