Repository navigation
Migration guide for window singleton deprecation - #8283
Merged
Merged
Conversation
goderbauer
force-pushed
the
windowSingleton
branch
from
February 17, 2023 23:17
ada93c4 to
068490a
Compare
Member
Author
|
@pdblasi-google Could you fill in the testing framework details? I left some TODOs for those. I think it makes sense that we cover those deprecations in the same migration guide to keep everything together. |
33 tasks done
loic-sharma
reviewed
Feb 17, 2023
loic-sharma
reviewed
Feb 17, 2023
loic-sharma
reviewed
Feb 17, 2023
loic-sharma
reviewed
Feb 17, 2023
dkwingsmt
reviewed
Feb 17, 2023
loic-sharma
reviewed
Feb 17, 2023
dkwingsmt
reviewed
Feb 17, 2023
goderbauer
force-pushed
the
windowSingleton
branch
from
March 4, 2023 00:15
0991a6e to
235ab85
Compare
goderbauer
force-pushed
the
windowSingleton
branch
from
March 4, 2023 00:16
235ab85 to
20f41c5
Compare
This was referenced Mar 8, 2023
Merged
goderbauer
commented
Mar 21, 2023
goderbauer
marked this pull request as ready for review
March 21, 2023 16:28
goderbauer
requested review from
atsansone,
domesticmouse,
johnpryan,
khanhnwin and
sfshaza2
as code owners
March 21, 2023 16:28
goderbauer
changed the title
goderbauer
commented
Mar 21, 2023
Member
Author
|
@sfshaza2 could you review this when you have a chance? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#116929.
Presubmit checklist