Repository navigation
Add TabBar.tabAlignment migration guide - #8700
Merged
Merged
Conversation
TahaTesser
requested review from
atsansone,
domesticmouse,
johnpryan,
khanhnwin,
parlough and
sfshaza2
as code owners
May 17, 2023 14:22
8 tasks done
Piinks
reviewed
May 19, 2023
Piinks
reviewed
May 19, 2023
Piinks
reviewed
May 19, 2023
Piinks
left a comment
Piinks
left a comment
Contributor
There was a problem hiding this comment.
This is great! Just a couple of small nits
atsansone
suggested changes
May 22, 2023
atsansone
left a comment
atsansone
left a comment
Contributor
There was a problem hiding this comment.
@TahaTesser : A few changes for length and semantic breaks. Thanks!
Contributor
Author
|
@atsansone |
Piinks
reviewed
May 24, 2023
|
|
||
| When you set `ThemeData.useMaterial3` to `true`, | ||
| a scrollable `TabBar` aligns tabs as `TabAlignment.startOffset` by default. | ||
| To change this alignment, set the `TabBar.tabAlignment` property. |
Contributor
There was a problem hiding this comment.
You can also use the theme, correct?
atsansone
approved these changes
May 25, 2023
atsansone
left a comment
atsansone
left a comment
Contributor
There was a problem hiding this comment.
@TahaTesser : I'll approve this as is. Keep in mind for next time that we hard wrap lines at 80 characters. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes flutter/flutter#126920
TabBar.tabAlignment was introduced in flutter/flutter#125036
This PR adds a migration guide for
TabBar.tabAlignment.Related flutter/flutter#125974
Presubmit checklist