Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter-team-archive/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 09fe990ebfcf
Choose a base ref
...
head repository: flutter-team-archive/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: aa3239cf3c01
Choose a head ref
  • 5 commits
  • 18 files changed
  • 2 contributors

Commits on Jul 17, 2023

  1. Roll Dart SDK from 827259dfffb9 to c1bfb2689f6f (1 revision) (#43735) 

    https://dart.googlesource.com/sdk.git/+log/827259dfffb9..c1bfb2689f6f

2023-07-16 [email protected] Version 3.1.0-318.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Jul 17, 2023
    Configuration menu
    Copy the full SHA
    66bdfc4 View commit details
    Browse the repository at this point in the history

  2. Roll Fuchsia Mac SDK from VYjne_BEm9inQ5fnq... to jtvD_HgQVBqadF3jX... ( 

    #43736)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Jul 17, 2023
    Configuration menu
    Copy the full SHA
    28c4db9 View commit details
    Browse the repository at this point in the history

  3. Roll Skia from 288c98d7ef0b to 4ec9f2497be1 (1 revision) (#43738) 

    https://skia.googlesource.com/skia.git/+log/288c98d7ef0b..4ec9f2497be1

2023-07-17 [email protected] Roll Skia Infra from 845e8105edb3 to 59a5e9ba0f61 (3 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Jul 17, 2023
    Configuration menu
    Copy the full SHA
    939fb4e View commit details
    Browse the repository at this point in the history

  4. Roll Skia from 4ec9f2497be1 to dc93f341ec38 (10 revisions) (#43739) 

    https://skia.googlesource.com/skia.git/+log/4ec9f2497be1..dc93f341ec38

2023-07-17 [email protected] check bounds and lengths in SkSpan
2023-07-17 [email protected] Remove SkCanvas::flush() call from skottielib
2023-07-17 [email protected] [skif] Remove legacy Tile implementation
2023-07-17 [email protected] Revert "Revert "Decouple SkMesh from Ganesh backend""
2023-07-17 [email protected] Replace SK_WARN_UNUSED_RESULT with C++17 [[nodiscard]].
2023-07-17 [email protected] Reland "Remove #ifdefs related to SkMesh and SkSL-dependent code."
2023-07-17 [email protected] Replace SK_UNUSED with C++17 [[maybe_unused]].
2023-07-17 [email protected] Roll Dawn from eb355bb3edcf to 2060ca2e3d59 (15 revisions)
2023-07-17 [email protected] Roll ANGLE from 6ffd0d20684d to 507f67ccff45 (14 revisions)
2023-07-17 [email protected] Roll SK Tool from 59a5e9ba0f61 to fe667086d4ee

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Jul 17, 2023
    Configuration menu
    Copy the full SHA
    b22d553 View commit details
    Browse the repository at this point in the history

  5. [fuchsia] flutter-embedder-test and touch-input-test use Flatland Tes… 

    …t UI Stack (#43562)

This change also:
- removes reliance from both tests on `fuchsia.ui.scenic.Scenic`
protocols
- migrates `touch-input-test` to get display info from
`fuchsia.ui.display.singleton.Info` instead of
`fuchsia.ui.gfx.DisplayInfo`
- adds support for `fuchsia.ui.display.singleton.Info` in
`portable_ui_test` to support the above
- migrates `flutter-embedder-test` to capture screenshots using
`fuchsia.ui.composition.Screenshot` instead of
`fuchsia.ui.scenic.Screenshot`
  - updates screenshot tooling accordingly
- removes the embedding view hit test disabled case from `touch-input
test`, since disabling the hit region is not currently supported in
Flutter's integration with Flatland afaict ([this
logic](https://github.com/flutter/engine/blob/0f0436b28430bd79e854f2294a60aa33417068fa/shell/platform/fuchsia/flutter/flatland_external_view_embedder.cc#L411-L434)
appears to set hit regions to the full view size by default, and
Flatland appears to drop the value
[here](https://github.com/flutter/engine/blob/0f0436b28430bd79e854f2294a60aa33417068fa/shell/platform/fuchsia/flutter/flatland_external_view_embedder.cc#L578))
- removes hit test configurability on `touch-input-test` and
`flutter-embedder-test` embedding views

Bug: fxbug.dev/125514
    @caroqliu
    caroqliu authored Jul 17, 2023
    Configuration menu
    Copy the full SHA
    aa3239c View commit details
    Browse the repository at this point in the history
Loading