Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter-team-archive/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: cf975417ce40
Choose a base ref
...
head repository: flutter-team-archive/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: fddd5add8b62
Choose a head ref
  • 3 commits
  • 16 files changed
  • 2 contributors

Commits on Apr 26, 2023

  1. Download and use the goma client from cipd (#41488) 

    In flutter/flutter#125361 we discovered that a
new version of clang can require updating goma in order for goma to work
properly. This PR adds a dependency on CIPD goma to the DEPS file so
that we can update it for use in local builds when needed. Since CI does
its own management of the goma client and the compiler proxy, and since
goma can only be used by Googlers, the DEPS file download is guarded
behind the `use_cipd_goma` gclient var. To use it one would update the
engine `.gclient` file to be something like:
```
~/flutter/engine/src $ cat ../.gclient
solutions = [
  {
    "managed": False,
    "name": "src/flutter",
    "url": "[email protected]:zanderso/engine.git",
    "custom_deps": {},
    "custom_vars": {
      "use_cipd_goma": True,
    },
    "deps_file": "DEPS",
    "safesync_url": "",
  },
]
```

I'll update the wiki with these instructions after this PR lands.
    @zanderso
    zanderso authored Apr 26, 2023
    Configuration menu
    Copy the full SHA
    aff8cbe View commit details
    Browse the repository at this point in the history

  2. Manual clang roll to 5344d8e10bb7d8672d4bfae8adb010465470d51b (#41520)

    @zanderso
    zanderso authored Apr 26, 2023
    Configuration menu
    Copy the full SHA
    ff92235 View commit details
    Browse the repository at this point in the history

  3. [Impeller] Use a device buffer for SkBitmap allocation, use Linear te… 

    …xture on Metal backend. (#41374)

This reduces the cost of uploading the glyph atlas, as we can exploit metal's capabilies to create a texture from a device buffer and share the underlying memory with a linear texture. This also means that subsequent updates don't require uploads or copies either.

From scrolling through wonderous, this shaves off about 0.2 ms (0.6 ms -> 0.4 ms) of fresh atlas construction.
    Jonah Williams
    Jonah Williams authored Apr 26, 2023
    Configuration menu
    Copy the full SHA
    fddd5ad View commit details
    Browse the repository at this point in the history
Loading