Skip to content
This repository was archived by the owner on Jun 8, 2026. It is now read-only.
This repository was archived by the owner on Jun 8, 2026. It is now read-only.

Re-enable web benchmarks #463

Closed
Closed

Description

@guidezpl

It seems Chrome 89 brought a change that causes the benchmarks to fail. To enable development, they've been disabled.

Activity

  1. guidezpl commented on Dec 9, 2021

    @guidezpl
    ContributorAuthor

    Hey @pennzht could you take a look? Benchmarks aren't currently running

  2. amanv8060 commented on Dec 13, 2021

    @amanv8060
    Contributor

    Hi @guidezpl , I have made pr here to add the changes introduced, but this pr requires knowledge of setting up the tests from basics, which I don't know . I would be more than happy to read something to get started on writing tests.

  3. guidezpl commented on Dec 13, 2021

    @guidezpl
    ContributorAuthor

    Oh nice, thanks. I don't have any more specific knowledge for testing than the guides on the Dart and Flutter docs sites. I'm not aware of browser testing that is version specific, do you have more info @yjbanov?

  4. yjbanov commented on Feb 17, 2022

    @yjbanov
    Contributor

    @ditman and @amanv8060 just fixed package:web_benchmarks. @ditman will attempt to reenable the gallery benchmark now.

  5. ditman commented on Feb 17, 2022

    @ditman
    Contributor

    Here's the PR reenabling the web benchmarks: https://github.com/flutter/gallery/pull/604

    I hope it helps. Thanks to @amanv8060 for the initial fix to web_benchmarks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

P1Priority 1 - Must havebugSomething isn't working

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions