Fix http2 request with node 10. - #1414
Conversation
|
Thanks for the fix! Do you know if express plans to release HTTP/2 soon? I'd rather use a dependency from npm than git. |
|
Sorry, I don't know, but I guess it need some more time, because there still have a nodejs bug with Express. As Express expose there internal request and response class, we can use Express released on npm with porting http2 implements in git version. I will try it later! |
|
@sogaani is actively working to get Express.js working with HTTP/2. Of course, Express tests itself with And yes, we've been slowing grinding through Node.js bugs as we uncover them, as Express.js exercises a lot of the HTTP server implementation. |
|
I don't know why If express needs to have HTTP/2 support in order to hand HTTP/2 support in superagent and Express needs superagent to have HTTP/2 support in order to land the support, I think we're in a catch 22 situation here. |
|
@dougwilson superagent use Express in test. For testing same test cases with HTTP/2, we need Express with HTTP/2 support.
Don't worry. Express does not need waiting HTTP/2 support in superagent, because superagent expose their request object and we can exchange them with HTTP2 supported request object. I did it in Express PR. |
1db3a4b to
575ca5e
Compare
|
I deleted dependency with forked Express by porting Express codes supporting HTTP/2. If release Express supporting HTTP/2, I would make PR to delete duplicate codes. |
|
Thanks! |
HTTP/2 with node 10 did not work, because we can not use setNoDelay with HTTP/2 socket.
This PR disable
request.setNoDelayon http2.